Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 1420973002: Add type cast definitions for CPDF_Reference. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
index 16124a3c38dbae0694e2560e0d1413d9251a090a..54cce94b9f0f1483de2b9c44a62f41e680983018 100644
--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
@@ -64,7 +64,7 @@ int32_t PDF_CreatorAppendObject(const CPDF_Object* pObj,
if (pFile->AppendString(FX_BSTRC(" ")) < 0) {
return -1;
}
- CPDF_Reference* p = (CPDF_Reference*)pObj;
+ const CPDF_Reference* p = pObj->AsReference();
Lei Zhang 2015/10/22 21:26:51 I think you can just fold |p| into the next line.
dsinclair 2015/10/26 13:55:44 Done.
if ((len = pFile->AppendDWord(p->GetRefObjNum())) < 0) {
return -1;
}
@@ -1171,7 +1171,7 @@ int32_t CPDF_Creator::WriteDirectObj(FX_DWORD objnum,
if (m_File.AppendString(FX_BSTRC(" ")) < 0) {
return -1;
}
- CPDF_Reference* p = (CPDF_Reference*)pObj;
+ const CPDF_Reference* p = pObj->AsReference();
if ((len = m_File.AppendDWord(p->GetRefObjNum())) < 0) {
return -1;
}

Powered by Google App Engine
This is Rietveld 408576698