[Interpreter]: Add ignition blacklist to mjsunit.status and test262.status.

[Interpreter]: Add ignition blacklist to mjsunit.status and test262.status.

Adds a blacklist of tests which are currently unsupported or broken in Ignition to
the mjsunit and test262 test status.

Also removes --ignition-script-filter flag, and adds a
--ignition_fallback_on_eval_and_catch flag which fallsback to fullcodegen for
functions which call eval or contain a catch block.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/fb9ad89fea2df498827295537516ab7996dc9798
Cr-Commit-Position: refs/heads/master@{#31864}

[rmcilroy, 2015-11-05 14:57:55]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2015-11-05 14:58:02]

Patchset #1 (id:20001) has been deleted

[rmcilroy, 2015-11-05 15:00:01]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 15:00:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420963009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420963009/40001

[rmcilroy, 2015-11-05 15:01:42]

rmcilroy@chromium.org changed reviewers:
+ machenbach@chromium.org, mstarzinger@chromium.org

[rmcilroy, 2015-11-05 15:01:42]

Michi: Could you take a look at src/compiler please.
Michael: Could you take a look at /tools and /tests please.

Thanks.

[commit-bot: I haz the power, 2015-11-05 17:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 17:26:37]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2015-11-05 18:21:43]

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode708
src/compiler.cc:708: static bool TopLevelFunctionPassesFilter(const char*
raw_filter) {
nit: Same comment as below, I assume this is temporary.

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode714
src/compiler.cc:714: static bool IgnitionShouldFallbackToFullCodeGen(Scope*
scope) {
nit: Can we add a TODO here saying that this is a temporary workaround for now
to get things running. I assume this will disappear once Ignition can handle
"eval" and "catch" properly.

[rmcilroy, 2015-11-06 09:51:14]

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode708
src/compiler.cc:708: static bool TopLevelFunctionPassesFilter(const char*
raw_filter) {
On 2015/11/05 18:21:43, Michael Starzinger wrote:
> nit: Same comment as below, I assume this is temporary.

The one below is temporary, however this one I think is necessary (for at least
as long as filter-ignition is around) since otherwise there is no way to filter
top-level scripts (even although PassesFilter() explicitly mentions top-level
function filtering), thus you can select a single function for running through
ignition without running top-level code (which we do in the cc tests).

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode714
src/compiler.cc:714: static bool IgnitionShouldFallbackToFullCodeGen(Scope*
scope) {
On 2015/11/05 18:21:43, Michael Starzinger wrote:
> nit: Can we add a TODO here saying that this is a temporary workaround for now
> to get things running. I assume this will disappear once Ignition can handle
> "eval" and "catch" properly.

Done.

[Michael Starzinger, 2015-11-06 10:06:30]

LGTM, cool stuff, just one nit.

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode708
src/compiler.cc:708: static bool TopLevelFunctionPassesFilter(const char*
raw_filter) {
On 2015/11/06 09:51:14, rmcilroy wrote:
> On 2015/11/05 18:21:43, Michael Starzinger wrote:
> > nit: Same comment as below, I assume this is temporary.
> 
> The one below is temporary, however this one I think is necessary (for at
least
> as long as filter-ignition is around) since otherwise there is no way to
filter
> top-level scripts (even although PassesFilter() explicitly mentions top-level
> function filtering), thus you can select a single function for running through
> ignition without running top-level code (which we do in the cc tests).

Acknowledged. You are right, makes sense. Can we move it to before the
"CompileUnoptimizedCode" helper then? In the end the two
"CompileUnoptimizedCode" and "GenerateBytecode" should live side by side, so
that the symmetry is obvious.

[rmcilroy, 2015-11-06 10:50:20]

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode708
src/compiler.cc:708: static bool TopLevelFunctionPassesFilter(const char*
raw_filter) {
On 2015/11/06 10:06:30, Michael Starzinger wrote:
> On 2015/11/06 09:51:14, rmcilroy wrote:
> > On 2015/11/05 18:21:43, Michael Starzinger wrote:
> > > nit: Same comment as below, I assume this is temporary.
> > 
> > The one below is temporary, however this one I think is necessary (for at
> least
> > as long as filter-ignition is around) since otherwise there is no way to
> filter
> > top-level scripts (even although PassesFilter() explicitly mentions
top-level
> > function filtering), thus you can select a single function for running
through
> > ignition without running top-level code (which we do in the cc tests).
> 
> Acknowledged. You are right, makes sense. Can we move it to before the
> "CompileUnoptimizedCode" helper then? In the end the two
> "CompileUnoptimizedCode" and "GenerateBytecode" should live side by side, so
> that the symmetry is obvious.

Move above CompileTopLevel since that is where it's used. Does this work for
you?

[Michael Starzinger, 2015-11-06 10:51:42]

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1420963009/diff/40001/src/compiler.cc#newcode708
src/compiler.cc:708: static bool TopLevelFunctionPassesFilter(const char*
raw_filter) {
On 2015/11/06 10:50:19, rmcilroy wrote:
> On 2015/11/06 10:06:30, Michael Starzinger wrote:
> > On 2015/11/06 09:51:14, rmcilroy wrote:
> > > On 2015/11/05 18:21:43, Michael Starzinger wrote:
> > > > nit: Same comment as below, I assume this is temporary.
> > > 
> > > The one below is temporary, however this one I think is necessary (for at
> > least
> > > as long as filter-ignition is around) since otherwise there is no way to
> > filter
> > > top-level scripts (even although PassesFilter() explicitly mentions
> top-level
> > > function filtering), thus you can select a single function for running
> through
> > > ignition without running top-level code (which we do in the cc tests).
> > 
> > Acknowledged. You are right, makes sense. Can we move it to before the
> > "CompileUnoptimizedCode" helper then? In the end the two
> > "CompileUnoptimizedCode" and "GenerateBytecode" should live side by side, so
> > that the symmetry is obvious.
> 
> Move above CompileTopLevel since that is where it's used. Does this work for
> you?

Acknowledged. Even better! :)

[Michael Achenbach, 2015-11-06 10:58:46]

lgtm

https://codereview.chromium.org/1420963009/diff/100001/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/1420963009/diff/100001/tools/run-tests.py#new...
tools/run-tests.py:686: "ignition": options.ignition,
Please add a "ignition": False to run-deopt-fuzzer.py in the same place.

[rmcilroy, 2015-11-06 17:40:02]

https://codereview.chromium.org/1420963009/diff/100001/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/1420963009/diff/100001/tools/run-tests.py#new...
tools/run-tests.py:686: "ignition": options.ignition,
On 2015/11/06 10:58:46, Michael Achenbach wrote:
> Please add a "ignition": False to run-deopt-fuzzer.py in the same place.

Done.

[rmcilroy, 2015-11-06 17:40:06]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-11-06 17:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1420963009/#ps120001
(title: "Add ignition variable to run-deopt-fuzzer")

[commit-bot: I haz the power, 2015-11-06 17:40:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420963009/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420963009/120001

[commit-bot: I haz the power, 2015-11-06 18:52:37]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-11-06 18:52:58]

Patchset 5 (id:??) landed as
https://crrev.com/fb9ad89fea2df498827295537516ab7996dc9798
Cr-Commit-Position: refs/heads/master@{#31864}