media: Compute proper VideoFrame::coded_rect for copies to GMBs.

media: Compute compatible VideoFrame::coded_rect for copies to GMBs.

Before this patch, GMBVFP would copy only visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we compute a format compatible coded_rect and we use
that as the new coded rect for copies and the new output VideoFrame.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/adb69b1408b5bb2f643c5b629e01a78068f7af5c
Cr-Commit-Position: refs/heads/master@{#356090}

[Daniele Castagna, 2015-10-22 18:15:48]

Patchset #2 (id:20001) has been deleted

[Daniele Castagna, 2015-10-22 18:34:53]

Description was changed from

==========
Copy videoframe coded_rect into GMBs.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have odd dimensions.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being significantly smaller than coded_size
we're going to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2015-10-22 18:39:12]

Description was changed from

==========
Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have odd dimensions.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being significantly smaller than coded_size
we're going to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have odd dimensions.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being significantly smaller than coded_size
we're going to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2015-10-22 18:40:03]

Description was changed from

==========
media: Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have odd dimensions.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being significantly smaller than coded_size
we're going to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being significantly smaller than coded_size
we're going to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2015-10-22 18:41:46]

dcastagna@chromium.org changed reviewers:
+ ccameron@chromium.org, emircan@chromium.org

[Daniele Castagna, 2015-10-22 18:50:01]

Description was changed from

==========
media: Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being significantly smaller than coded_size
we're going to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being smaller than coded_size we're going
to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera and VideoFrame needs to be letterboxed.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2015-10-22 19:03:17]

lgtm

[Daniele Castagna, 2015-10-22 19:13:54]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org, sandersd@chromium.org

[Daniele Castagna, 2015-10-22 19:13:55]

Adding owners:
+reveman for cc/layers/*
+sandersd for media/video/*

[reveman, 2015-10-22 19:22:15]

lgtm

[sandersd (OOO until July 31), 2015-10-22 19:33:14]

lgtm

[Daniele Castagna, 2015-10-22 19:34:14]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2015-10-22 19:35:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420943002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420943002/40001

[emircan, 2015-10-22 19:39:21]

lgtm

[commit-bot: I haz the power, 2015-10-22 21:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 21:07:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Daniele Castagna, 2015-10-23 21:48:25]

Description was changed from

==========
media: Copy VideoFrame::coded_rect into GMBs.

Before this patch, GMBVFP would copy only the visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we copy coded_rect to GMBs.

In case of visible_rect being smaller than coded_size we're going
to copy more data after this patch.
This in practice only happens in rare occasions where the source
of the video is a camera and VideoFrame needs to be letterboxed.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Compute proper VideoFrame::coded_rect for copies to GMBs.

Before this patch, GMBVFP would copy only visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we compute an format compatible coded_rect and we use
that as the coded rect for copies and the output VideoFrame.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2015-10-23 21:58:50]

Description was changed from

==========
media: Compute proper VideoFrame::coded_rect for copies to GMBs.

Before this patch, GMBVFP would copy only visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we compute an format compatible coded_rect and we use
that as the coded rect for copies and the output VideoFrame.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Compute proper VideoFrame::coded_rect for copies to GMBs.

Before this patch, GMBVFP would copy only visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we compute a format compatible coded_rect and we use
that as the new coded rect for copies and the new output VideoFrame.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2015-10-23 22:12:45]

Description was changed from

==========
media: Compute proper VideoFrame::coded_rect for copies to GMBs.

Before this patch, GMBVFP would copy only visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we compute a format compatible coded_rect and we use
that as the new coded rect for copies and the new output VideoFrame.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
media: Compute compatible VideoFrame::coded_rect for copies to GMBs.

Before this patch, GMBVFP would copy only visible_rect to
GpuMemoryBuffers.
Unfortunately GMBs can't always be created with visible_rect size
since visible_rect might have dimensions not compatible with the
output format.

With this patch we compute a format compatible coded_rect and we use
that as the new coded rect for copies and the new output VideoFrame.

BUG=544554
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Daniele Castagna, 2015-10-23 22:13:29]

I had to change the logic a little to fix the bug.
The previous patch would break some tests since we don't always correctly draw
native videoframes  when visible_rect is not in the origin (video to canvas
ignores that.)

Now the output videoframe visible_rect is always in the origin, as it was
before, but coded_size of the output videoframe is computed to be compatible
with the output format.

[emircan, 2015-10-26 18:02:59]

still lgtm

[Daniele Castagna, 2015-10-26 18:03:37]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2015-10-26 18:03:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, reveman@chromium.org, sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/1420943002/#ps80001
(title: "Rebase on master.")

[commit-bot: I haz the power, 2015-10-26 18:04:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420943002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420943002/80001

[commit-bot: I haz the power, 2015-10-26 19:07:35]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-10-26 19:08:25]

Patchset 4 (id:??) landed as
https://crrev.com/adb69b1408b5bb2f643c5b629e01a78068f7af5c
Cr-Commit-Position: refs/heads/master@{#356090}