Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420923006: Add unique serial numbers to sample X509 certificates. Remove the "sendClientCertificate" parameter… (Closed)

Created:
5 years, 1 month ago by Bill Hesse
Modified:
5 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add unique serial numbers to sample X509 certificates. Remove the "sendClientCertificate" parameter from SecureSocket.connect. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/169b132a6366c0058db43a5e5f2eae3b09032ec9

Patch Set 1 #

Patch Set 2 : Delete all certificate signing private keys, so testers aren't vulnerable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -344 lines) Patch
M runtime/bin/io_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 3 chunks +1 line, -5 lines 0 comments Download
M runtime/bin/secure_socket_patch.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/secure_socket.dart View 7 chunks +12 lines, -17 lines 0 comments Download
M tests/standalone/io/certificates/client1.pem View 1 chunk +17 lines, -17 lines 0 comments Download
M tests/standalone/io/certificates/client1_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M tests/standalone/io/certificates/client2.pem View 1 chunk +17 lines, -17 lines 0 comments Download
M tests/standalone/io/certificates/client2_key.pem View 1 chunk +27 lines, -28 lines 0 comments Download
M tests/standalone/io/certificates/client_authority.pem View 1 chunk +15 lines, -15 lines 0 comments Download
M tests/standalone/io/certificates/server_chain.pem View 1 chunk +47 lines, -47 lines 0 comments Download
M tests/standalone/io/certificates/server_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M tests/standalone/io/certificates/server_trusted.pem View 1 chunk +46 lines, -46 lines 0 comments Download
M tests/standalone/io/certificates/trusted_certs.pem View 1 chunk +14 lines, -14 lines 0 comments Download
M tests/standalone/io/certificates/untrusted_server_chain.pem View 1 chunk +46 lines, -46 lines 0 comments Download
M tests/standalone/io/certificates/untrusted_server_key.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M tests/standalone/io/create_sample_certificates.sh View 1 2 chunks +11 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_client.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 1 month ago (2015-10-27 12:24:50 UTC) #2
Søren Gjesse
lgtm
5 years, 1 month ago (2015-10-29 12:13:47 UTC) #3
Bill Hesse
5 years, 1 month ago (2015-10-29 12:17:27 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
169b132a6366c0058db43a5e5f2eae3b09032ec9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698