Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1420913003: [turbofan] Try hard(er) to use smi representation for float64 values. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Try hard(er) to use smi representation for float64 values. Previously ChangeLowering would always box float64 values when going to tagged representation, but that introduces a lot of deoptimizer loops and polymorphism into TurboFan, which is unfortunate and unnecessary. This adds some logic to ChangeFloat64ToTagged to try harder to create a Smi when going from Float64 to Tagged, instead of always allocating a HeapNumber. This might need some additional tweaking, but at least it makes it possible to start comparing TurboFan and Crankshaft for some regular JavaScript. R=jarin@chromium.org Committed: https://crrev.com/7709e41aec9de8b42ddebb197a02c1017d6fe87a Cr-Commit-Position: refs/heads/master@{#31609}

Patch Set 1 #

Patch Set 2 : Remove unittest for now. Will need new ones, once we know what we want. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -42 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +72 lines, -1 line 2 comments Download
D test/mjsunit/regress/regress-460937.js View 1 chunk +0 lines, -19 lines 0 comments Download
M test/mjsunit/regress/regress-95113.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-485410.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-27 14:03:15 UTC) #1
Benedikt Meurer
Jaro: PTAL Danno: FYI
5 years, 1 month ago (2015-10-27 14:03:43 UTC) #2
Jarin
lgtm https://codereview.chromium.org/1420913003/diff/20001/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/1420913003/diff/20001/src/compiler/change-lowering.cc#newcode225 src/compiler/change-lowering.cc:225: return Replace(value); Just wondering - is there a ...
5 years, 1 month ago (2015-10-27 15:17:03 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1420913003/diff/20001/src/compiler/change-lowering.cc File src/compiler/change-lowering.cc (right): https://codereview.chromium.org/1420913003/diff/20001/src/compiler/change-lowering.cc#newcode225 src/compiler/change-lowering.cc:225: return Replace(value); Allocate requires a control input.
5 years, 1 month ago (2015-10-27 16:16:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420913003/20001
5 years, 1 month ago (2015-10-27 16:16:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 16:17:48 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 16:18:29 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7709e41aec9de8b42ddebb197a02c1017d6fe87a
Cr-Commit-Position: refs/heads/master@{#31609}

Powered by Google App Engine
This is Rietveld 408576698