Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1420883002: Fix user options for fractional digits in Intl.NumberFormatter (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix user options for fractional digits in Intl.NumberFormatter The patch in https://crrev.com/ddb5c2d999c5ee6e31c4a9599bb3ddb293cc3f49 moved all fractional digit settings to default values due to a coding error. These were not even correct default values, and users observed errors where percentages were written as "23.0%" instead of "23%". This patch fixes the setting propagation when appropriate and it changes the default max fractional digits of a percentage to 0, per spec. BUG=chromium:544122 R=mnita,jochen CC=hichris123,adamk LOG=Y Committed: https://crrev.com/f5e924eb10060d355e693ce4ce9ce0aaf3a8411f Cr-Commit-Position: refs/heads/master@{#31468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -5 lines) Patch
M src/js/i18n.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/intl/number-format/check-minimum-fraction-digits.js View 1 chunk +50 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420883002/1
5 years, 2 months ago (2015-10-22 09:02:16 UTC) #2
Dan Ehrenberg
5 years, 2 months ago (2015-10-22 09:02:39 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 09:23:45 UTC) #7
mnita
On 2015/10/22 09:23:45, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-10-22 11:01:56 UTC) #13
mnita
lgtm
5 years, 2 months ago (2015-10-22 11:02:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420883002/1
5 years, 2 months ago (2015-10-22 11:29:13 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 11:30:49 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 11:31:27 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5e924eb10060d355e693ce4ce9ce0aaf3a8411f
Cr-Commit-Position: refs/heads/master@{#31468}

Powered by Google App Engine
This is Rietveld 408576698