Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1420863003: Use the original paint invalidation path for sync painting v1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 && previousPaintInvalidationRect != this->previousPaintInvalidationRect( ) 377 && previousPaintInvalidationRect != this->previousPaintInvalidationRect( )
378 && !usesCompositedScrolling() 378 && !usesCompositedScrolling()
379 && hasOverflowClip()) 379 && hasOverflowClip())
380 childTreeWalkState.setForceSubtreeInvalidationRectUpdateWithinContainer( ); 380 childTreeWalkState.setForceSubtreeInvalidationRectUpdateWithinContainer( );
381 381
382 invalidatePaintOfSubtreesIfNeeded(childTreeWalkState); 382 invalidatePaintOfSubtreesIfNeeded(childTreeWalkState);
383 } 383 }
384 384
385 void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe ct& r, PaintInvalidationReason invalidationReason) const 385 void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe ct& r, PaintInvalidationReason invalidationReason) const
386 { 386 {
387 ASSERT(!RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()); 387 ASSERT(!RuntimeEnabledFeatures::slimmingPaintV2Enabled());
388 388
389 // https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here, 389 // https://bugs.webkit.org/show_bug.cgi?id=61159 describes an unreproducible crash here,
390 // so assert but check that the layer is composited. 390 // so assert but check that the layer is composited.
391 ASSERT(compositingState() != NotComposited); 391 ASSERT(compositingState() != NotComposited);
392 392
393 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic. 393 // FIXME: generalize accessors to backing GraphicsLayers so that this code i s squashing-agnostic.
394 if (layer()->groupedMapping()) { 394 if (layer()->groupedMapping()) {
395 LayoutRect paintInvalidationRect = r; 395 LayoutRect paintInvalidationRect = r;
396 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) { 396 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) {
397 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 397 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
(...skipping 659 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 if (rootElementStyle->hasBackground()) 1057 if (rootElementStyle->hasBackground())
1058 return false; 1058 return false;
1059 1059
1060 if (node() != document().firstBodyElement()) 1060 if (node() != document().firstBodyElement())
1061 return false; 1061 return false;
1062 1062
1063 return true; 1063 return true;
1064 } 1064 }
1065 1065
1066 } // namespace blink 1066 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698