Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14208019: Change MessageService to use ProfileKeyedAPI. (Closed)

Created:
7 years, 8 months ago by Patrick Riordan
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change MessageService to use ProfileKeyedAPI. BUG=179951 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198993

Patch Set 1 #

Total comments: 4

Patch Set 2 : Convenience method and correct initialization #

Patch Set 3 : Fixed comment #

Patch Set 4 : Nicer line wrapping #

Total comments: 4

Patch Set 5 : Added Redirection in incognito and got rid of profile_ #

Patch Set 6 : Typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.h View 1 2 3 4 5 5 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 2 3 4 5 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 2 3 4 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 2 3 4 4 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/message_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 2 3 4 5 4 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Patrick Riordan
7 years, 8 months ago (2013-04-26 01:01:53 UTC) #1
Devlin
https://codereview.chromium.org/14208019/diff/1/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/14208019/diff/1/chrome/browser/extensions/api/messaging/message_service.cc#newcode153 chrome/browser/extensions/api/messaging/message_service.cc:153: lazy_background_task_queue_ = nit: You could initialize this right below ...
7 years, 8 months ago (2013-04-26 01:21:25 UTC) #2
Patrick Riordan
https://codereview.chromium.org/14208019/diff/1/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/14208019/diff/1/chrome/browser/extensions/api/messaging/message_service.cc#newcode153 chrome/browser/extensions/api/messaging/message_service.cc:153: lazy_background_task_queue_ = On 2013/04/26 01:21:25, D Cronin wrote: > ...
7 years, 8 months ago (2013-04-26 02:18:45 UTC) #3
Devlin
lgtm
7 years, 7 months ago (2013-04-29 19:55:54 UTC) #4
Patrick Riordan
+ yoz for chrome/browser/extensions/
7 years, 7 months ago (2013-04-30 22:15:31 UTC) #5
Yoyo Zhou
https://codereview.chromium.org/14208019/diff/11002/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/14208019/diff/11002/chrome/browser/extensions/api/messaging/message_service.cc#newcode147 chrome/browser/extensions/api/messaging/message_service.cc:147: : profile_(profile), Note you don't actually use profile_ anywhere ...
7 years, 7 months ago (2013-04-30 22:33:04 UTC) #6
Patrick Riordan
https://codereview.chromium.org/14208019/diff/11002/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/14208019/diff/11002/chrome/browser/extensions/api/messaging/message_service.cc#newcode147 chrome/browser/extensions/api/messaging/message_service.cc:147: : profile_(profile), On 2013/04/30 22:33:04, Yoyo Zhou wrote: > ...
7 years, 7 months ago (2013-05-01 01:54:44 UTC) #7
Yoyo Zhou
LGTM
7 years, 7 months ago (2013-05-01 04:27:41 UTC) #8
Ben Goodger (Google)
lgtm
7 years, 7 months ago (2013-05-01 16:00:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/14208019/20001
7 years, 7 months ago (2013-05-01 23:25:58 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=37328
7 years, 7 months ago (2013-05-02 01:32:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/patrickriordan177@gmail.com/14208019/19002
7 years, 7 months ago (2013-05-08 14:12:50 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 20:58:53 UTC) #13
Message was sent while issue was closed. 
Change committed as 198993

Powered by Google App Engine
This is Rietveld 408576698