Hookup RawVarData to SerializedVar

Hookup RawVarData to SerializedVar

This hooks up the rewritten RawVarData implementation with SerializedVar. It also fixes tests to make sure that shmem ArrayBuffers are actually tested. Previously, no testing of shmem ArrayBuffers was happening because OS_LINUX is never defined in ppapi/tests and none of the other ArrayBuffer test sizes were above the threshhold to invoke that code path. This CL adds a PPB_Testing function to set the threshhold to a lower value, which permits this code path to be taken while still having fast tests.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195189

[dmichael (off chromium), 2013-04-18 20:06:47]

Awesome, lgtm

+teravest, since he's most familiar with the shmem ArrayBuffer stuff, to
double-check the handle management.

https://codereview.chromium.org/14208016/diff/12001/ppapi/api/dev/ppb_testing...
File ppapi/api/dev/ppb_testing_dev.idl (right):

https://codereview.chromium.org/14208016/diff/12001/ppapi/api/dev/ppb_testing...
ppapi/api/dev/ppb_testing_dev.idl:141: [in] uint32_t threshhold);
nit: note somewhere that the unit is bytes? possibly call it
threshhold_in_bytes?

[teravest, 2013-04-18 20:15:04]

lgtm

Handle management looks reasonable to me.

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppapi_message...
ppapi/proxy/ppapi_messages.h:1144: uint32_t /* threshhold */)
threshold

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppb_testing_p...
File ppapi/proxy/ppb_testing_proxy.cc (right):

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppb_testing_p...
ppapi/proxy/ppb_testing_proxy.cc:118: uint32_t threshhold) {
s/threshhold/threshold/ throughout

[raymes, 2013-04-18 20:29:55]

https://codereview.chromium.org/14208016/diff/12001/ppapi/api/dev/ppb_testing...
File ppapi/api/dev/ppb_testing_dev.idl (right):

https://codereview.chromium.org/14208016/diff/12001/ppapi/api/dev/ppb_testing...
ppapi/api/dev/ppb_testing_dev.idl:141: [in] uint32_t threshhold);
On 2013/04/18 20:06:47, dmichael wrote:
> nit: note somewhere that the unit is bytes? possibly call it
> threshhold_in_bytes?

Done.

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppapi_message...
ppapi/proxy/ppapi_messages.h:1144: uint32_t /* threshhold */)
On 2013/04/18 20:15:04, teravest wrote:
> threshold

Done.

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppb_testing_p...
File ppapi/proxy/ppb_testing_proxy.cc (right):

https://codereview.chromium.org/14208016/diff/12001/ppapi/proxy/ppb_testing_p...
ppapi/proxy/ppb_testing_proxy.cc:118: uint32_t threshhold) {
On 2013/04/18 20:15:04, teravest wrote:
> s/threshhold/threshold/ throughout

Done.

[commit-bot: I haz the power, 2013-04-18 20:30:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/14208016/19001

[commit-bot: I haz the power, 2013-04-18 20:31:05]

Presubmit check for 14208016-19001 failed and returned exit status 1.

INFO:root:Found 13 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ppapi/PRESUBMIT.py

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  ppapi/proxy/serialized_var.cc:422
    inner_->ForceSetVarValueForTest(pod_var); \
  ppapi/proxy/serialized_var.cc:427
    inner_->ForceSetVarValueForTest(StringVar::StringToPPVar(str));

If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ppapi/proxy/ppapi_messages.h

Presubmit checks took 2.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[raymes, 2013-04-18 20:35:20]

Justin, please take a look at ppapi_messages.h.

I added one IPC, it is for testing purposes. The message handler in
ppb_testing_proxy.cc is guarded by:
if (!dispatcher()->permissions().HasPermission(PERMISSION_TESTING)) return false

which will prevent this being used in a release version of chrome.

[raymes, 2013-04-18 20:46:51]

-jschuh (who is swamped)
+tsepez for ppapi_messages.h. See the explanation in the above comment.

[jschuh, 2013-04-18 20:49:58]

On 2013/04/18 20:35:20, raymes wrote:
> Justin, please take a look at ppapi_messages.h.

I'm on vacation... but I do owe you.

> I added one IPC, it is for testing purposes. The message handler in
> ppb_testing_proxy.cc is guarded by:
> if (!dispatcher()->permissions().HasPermission(PERMISSION_TESTING)) return
false
> 
> which will prevent this being used in a release version of chrome.

Where does this check live?

[raymes, 2013-04-18 20:52:16]

haha thanks!

lives in: ppb_testing_proxy.cc. The first line in
PPB_Testing_Proxy::OnMessageReceived.

On Thu, Apr 18, 2013 at 1:49 PM,  <jschuh@chromium.org> wrote:
> On 2013/04/18 20:35:20, raymes wrote:
>>
>> Justin, please take a look at ppapi_messages.h.
>
>
> I'm on vacation... but I do owe you.
>
>
>> I added one IPC, it is for testing purposes. The message handler in
>> ppb_testing_proxy.cc is guarded by:
>> if (!dispatcher()->permissions().HasPermission(PERMISSION_TESTING)) return
>
> false
>
>> which will prevent this being used in a release version of chrome.
>
>
> Where does this check live?
>
>
> https://codereview.chromium.org/14208016/

[Tom Sepez, 2013-04-18 20:52:16]

Messages LGTM.

[commit-bot: I haz the power, 2013-04-18 21:33:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/14208016/19001

[commit-bot: I haz the power, 2013-04-18 21:33:34]

Presubmit check for 14208016-19001 failed and returned exit status 1.

INFO:root:Found 13 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1305, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1129, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1046, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 865, in CheckChangeOnCommit
  File "<string>", line 700, in _CommonChecks
  File "<string>", line 258, in _CheckNoUNIT_TESTInSourceFiles
  File "/b/depot_tools/presubmit_support.py", line 549, in ChangedContents
    for line in self.GenerateScmDiff().splitlines():
  File "/b/depot_tools/presubmit_support.py", line 619, in GenerateScmDiff
    [self.LocalPath()], self._local_root, False, None)
  File "/b/depot_tools/scm.py", line 913, in GenerateDiff
    full_move, revision))
  File "/b/depot_tools/scm.py", line 837, in _DiffItemInternal
    data = SVN.Capture(command, cwd)
  File "/b/depot_tools/scm.py", line 479, in Capture
    ['svn'] + args, stderr=subprocess2.PIPE, cwd=cwd, **kwargs)
  File "/b/depot_tools/subprocess2.py", line 449, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/depot_tools/subprocess2.py", line 412, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn diff --internal-diff
ppapi/proxy/handle_converter.cc returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium
svn: invalid option: --internal-diff
Type 'svn help' for usage.

[commit-bot: I haz the power, 2013-04-18 22:09:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/14208016/19001

[commit-bot: I haz the power, 2013-04-19 14:46:06]

Change committed as 195189