Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

Issue 14208014: Simplify adding callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
index eb11d4f7d518bd4ef6fcd4a49ce9c701b401ac83..a595e1af18a8a91edfd5567a440ade996809653b 100644
--- a/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
@@ -111,35 +111,20 @@ void EulaScreenHandler::OnPasswordFetched(const std::string& tpm_password) {
CallJS("cr.ui.Oobe.setTpmPassword", tpm_password_value);
}
-void EulaScreenHandler::HandleOnExit(const base::ListValue* args) {
- DCHECK(args->GetSize() == 2);
-
- bool accepted = false;
- if (!args->GetBoolean(0, &accepted))
- NOTREACHED();
-
- bool usage_stats_enabled = false;
- if (!args->GetBoolean(1, &usage_stats_enabled))
- NOTREACHED();
-
- if (!delegate_)
- return;
-
- delegate_->OnExit(accepted, usage_stats_enabled);
+void EulaScreenHandler::HandleOnExit(bool accepted, bool usage_stats_enabled) {
+ if (delegate_)
+ delegate_->OnExit(accepted, usage_stats_enabled);
}
-void EulaScreenHandler::HandleOnLearnMore(const base::ListValue* args) {
- if (!help_app_.get()) {
+void EulaScreenHandler::HandleOnLearnMore() {
+ if (!help_app_.get())
help_app_ = new HelpAppLauncher(GetNativeWindow());
- }
help_app_->ShowHelpTopic(HelpAppLauncher::HELP_STATS_USAGE);
}
-void EulaScreenHandler::HandleOnInstallationSettingsPopupOpened(
- const base::ListValue* args) {
- if (!delegate_)
- return;
- delegate_->InitiatePasswordFetch();
+void EulaScreenHandler::HandleOnInstallationSettingsPopupOpened() {
+ if (delegate_)
+ delegate_->InitiatePasswordFetch();
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698