Move StackTracer to sampler.h

src/sampler.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 96 matching lines @@
   Isolate* isolate_;
   const int interval_;
   Atomic32 profiling_;
   Atomic32 active_;
   PlatformData* data_;  // Platform specific data.
   int samples_taken_;  // Counts stack samples taken.
   DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler);
 };
 
 
+// Class that extracts stack trace, used for profiling.
+class StackTracer : public AllStatic {

[Sven Panne, 2013/04/17 07:00:37]

If we're honest, this is not a class at all. :-) Does it make sense to move
Trace to the TickSample class? Currently this looks very ugly (OK, it has been
ugly before, but I think we should fix this when moving things around.)

In general, when we have a static method, we should ask ourselves where the
right place for the code really is: It is probably in the classes which are
mentioned in the signature, most probably the one where the least feature envy
happens.

+ public:
+  static void Trace(Isolate* isolate, TickSample* sample);
+};
+
 } }  // namespace v8::internal
 
 #endif  // V8_SAMPLER_H_