Move StackTracer to sampler.h

Move StackTracer to sampler.h

Apart from tests Sampler is the only client of StackTracer so it is logical to move it into sampler.h

BUG=None

Committed: https://code.google.com/p/v8/source/detail?r=14298

[loislo, 2013-04-16 15:35:01]

lgtm

[Sven Panne, 2013-04-17 07:00:37]

If there are no technical reasons against this, let's move the Trace method
around before landing this, please.

https://codereview.chromium.org/14208012/diff/2001/src/sampler.h
File src/sampler.h (right):

https://codereview.chromium.org/14208012/diff/2001/src/sampler.h#newcode118
src/sampler.h:118: class StackTracer : public AllStatic {
If we're honest, this is not a class at all. :-) Does it make sense to move
Trace to the TickSample class? Currently this looks very ugly (OK, it has been
ugly before, but I think we should fix this when moving things around.)

In general, when we have a static method, we should ask ourselves where the
right place for the code really is: It is probably in the classes which are
mentioned in the signature, most probably the one where the least feature envy
happens.

[yurys, 2013-04-17 07:17:35]

On 2013/04/17 07:00:37, Sven Panne wrote:
> If there are no technical reasons against this, let's move the Trace method
> around before landing this, please.
> 
> https://codereview.chromium.org/14208012/diff/2001/src/sampler.h
> File src/sampler.h (right):
> 
> https://codereview.chromium.org/14208012/diff/2001/src/sampler.h#newcode118
> src/sampler.h:118: class StackTracer : public AllStatic {
> If we're honest, this is not a class at all. :-) Does it make sense to move
> Trace to the TickSample class? Currently this looks very ugly (OK, it has been
> ugly before, but I think we should fix this when moving things around.)
> 
> In general, when we have a static method, we should ask ourselves where the
> right place for the code really is: It is probably in the classes which are
> mentioned in the signature, most probably the one where the least feature envy
> happens.

Absolutely agree with you. Fixed that.

[Sven Panne, 2013-04-17 07:31:52]

lgtm

[yurys, 2013-04-17 07:53:23]

Committed patchset #5 manually as r14298 (presubmit successful).