Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1420783004: Last performed task diagnostics. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Last performed task diagnostics. Adds a new block of status that reports the last 10 performed tasks. For example: <p>Recent Tasks</p> GatherUsedLocalElementsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart GatherUsedImportedElementsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart GenerateHintsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart GenerateLintsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart VerifyUnitTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart LibraryUnitErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart DartErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart LibraryErrorsReadyTask for source /Users/pquitslund/src/git/clones/analyzer_cli/test/mocks.dart GetContentTask for source /Users/pquitslund/src/git/clones/analyzer_cli/.analysis_options GenerateOptionsErrorsTask for source /Users/pquitslund/src/git/clones/analyzer_cli/.analysis_options R=brianwilkerson@google.com, keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/d12abed5d72ae6676eda757fb0475c48d55b7a8b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Label. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 2 chunks +21 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
5 years, 2 months ago (2015-10-23 17:17:12 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1420783004/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1420783004/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode1018 pkg/analysis_server/lib/src/status/get_handler.dart:1018: buffer.write('<h3>Recent Tasks</h3>'); Maybe insert " (most recent last)".
5 years, 2 months ago (2015-10-23 17:28:31 UTC) #4
pquitslund
Thanks! https://codereview.chromium.org/1420783004/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart File pkg/analysis_server/lib/src/status/get_handler.dart (right): https://codereview.chromium.org/1420783004/diff/1/pkg/analysis_server/lib/src/status/get_handler.dart#newcode1018 pkg/analysis_server/lib/src/status/get_handler.dart:1018: buffer.write('<h3>Recent Tasks</h3>'); On 2015/10/23 17:28:31, Brian Wilkerson wrote: ...
5 years, 2 months ago (2015-10-23 17:30:03 UTC) #5
keertip
lgtm
5 years, 2 months ago (2015-10-23 17:31:01 UTC) #6
pquitslund
5 years, 2 months ago (2015-10-23 17:31:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d12abed5d72ae6676eda757fb0475c48d55b7a8b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698