Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 1420773003: scheduler: Don't block expensive loading tasks during main thread gestures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index 7e339c2169f1505e38b342d1cd322691becd01f4..238239966dff490b418b46796d35aff081bb5f0b 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -2150,6 +2150,27 @@ TEST_F(
EXPECT_THAT(run_order, testing::ElementsAre(std::string("D1")));
}
+TEST_F(RendererSchedulerImplTest,
+ ExpensiveLoadingTasksNotBlockedDuringMainThreadGestures) {
+ std::vector<std::string> run_order;
+
+ SimulateExpensiveTasks(loading_task_runner_);
+
+ // Loading tasks should not be disabled during main thread user user
+ // interactions.
+ PostTestTasks(&run_order, "C1 L1");
+
+ // Trigger main_thread_gesture UseCase
+ WillBeginMainThreadGestureFrame();
+ RunUntilIdle();
+ EXPECT_EQ(RendererScheduler::UseCase::MAIN_THREAD_GESTURE, CurrentUseCase());
+
+ EXPECT_TRUE(LoadingTasksSeemExpensive());
+ EXPECT_FALSE(TimerTasksSeemExpensive());
+ EXPECT_THAT(run_order,
+ testing::ElementsAre(std::string("C1"), std::string("L1")));
+}
+
TEST_F(RendererSchedulerImplTest, ModeratelyExpensiveTimer_NotBlocked) {
scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true);
for (int i = 0; i < 20; i++) {
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698