ipc: Move methods into AttachmentBroker interface.

ipc: Move methods into AttachmentBroker interface.

Consumers of AttachmentBroker typically get an instance with
AttachmentBroker::GetGlobal(). In order to use subclass methods, they had to
downcast. Move those subclass methods into the AttachmentBroker interface
removes the need to downcast.

BUG=535711
Committed: https://crrev.com/7b9f8959f25f144f6cfac5eec98485604a158284
Cr-Commit-Position: refs/heads/master@{#355364}

[erikchen, 2015-10-21 17:48:56]

erikchen@chromium.org changed reviewers:
+ tsepez@chromium.org

[erikchen, 2015-10-21 17:48:56]

tsepez: Please review.

[Tom Sepez, 2015-10-21 17:59:16]

LGTM after fixing nits.

https://codereview.chromium.org/1420763002/diff/1/ipc/attachment_broker.h
File ipc/attachment_broker.h (right):

https://codereview.chromium.org/1420763002/diff/1/ipc/attachment_broker.h#new...
ipc/attachment_broker.h:101: CHECK(!port_provider_);
DCHECK().  Check in a privileged process is usually undesirable.

https://codereview.chromium.org/1420763002/diff/1/ipc/attachment_broker.h#new...
ipc/attachment_broker.h:120: base::PortProvider* get_port_provider() { return
port_provider_; }
nit: const method, typical naming is just port_provider().

[erikchen, 2015-10-21 18:05:28]

https://codereview.chromium.org/1420763002/diff/1/ipc/attachment_broker.h
File ipc/attachment_broker.h (right):

https://codereview.chromium.org/1420763002/diff/1/ipc/attachment_broker.h#new...
ipc/attachment_broker.h:101: CHECK(!port_provider_);
On 2015/10/21 17:59:15, Tom Sepez wrote:
> DCHECK().  Check in a privileged process is usually undesirable.

Done.

https://codereview.chromium.org/1420763002/diff/1/ipc/attachment_broker.h#new...
ipc/attachment_broker.h:120: base::PortProvider* get_port_provider() { return
port_provider_; }
On 2015/10/21 17:59:15, Tom Sepez wrote:
> nit: const method, typical naming is just port_provider().

Done.

[erikchen, 2015-10-21 18:05:39]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-10-21 18:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1420763002/#ps20001
(title: "Comments from tsepez.")

[commit-bot: I haz the power, 2015-10-21 18:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420763002/20001

[commit-bot: I haz the power, 2015-10-21 18:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 18:09:42]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2015-10-21 18:14:17]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-10-21 18:14:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1420763002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-10-21 18:16:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420763002/40001

[erikchen, 2015-10-21 18:25:23]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2015-10-21 18:36:54]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-10-21 18:38:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420763002/40001

[commit-bot: I haz the power, 2015-10-21 19:18:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-21 19:19:11]

Patchset 3 (id:??) landed as
https://crrev.com/7b9f8959f25f144f6cfac5eec98485604a158284
Cr-Commit-Position: refs/heads/master@{#355364}