chrome/browser/android/shortcut_helper.h - Issue 1420743002: Web app: set a flag on the Intent if the icon was generated by Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 1420743002: Web app: set a flag on the Intent if the icon was generated by Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@splashscreen-even-more-tests

Patch Set: review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/shortcut_helper.h

diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h

index 12e47931b41aa571f7a0e4904815b429a373982d..4dcbcb131b3a3bded4415c27aa9ac6b57b14e370 100644

--- a/chrome/browser/android/shortcut_helper.h

+++ b/chrome/browser/android/shortcut_helper.h

@@ -53,6 +53,13 @@ class ShortcutHelper {

static void StoreWebappData(const std::string& webapp_id,

const SkBitmap& splash_image);

+ // Modify the given icon to matche the launcher requirements, then returns the

+ // new icon. It might generate an entirely new icon, in which case,

+ // |is_generated| will be set to |true|.

+ static SkBitmap FinalizeLauncherIcon(const SkBitmap& icon,

+ const GURL& url,

+ bool* is_generated);

private:

ShortcutHelper() = delete;

~ShortcutHelper() = delete;