chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h - Issue 1420743002: Web app: set a flag on the Intent if the icon was generated by Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 1420743002: Web app: set a flag on the Intent if the icon was generated by Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@splashscreen-even-more-tests

Patch Set: locally tested Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/shortcut_info.h ('K') | « chrome/browser/android/shortcut_info.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

index b3927ecc2869a6dc9e9537976e7af2782a882ae1..4e5e1dbc91a7ac38141bccf79cf2301d08077c20 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

@@ -41,8 +41,11 @@ class AddToHomescreenDataFetcher

virtual void OnUserTitleAvailable(const base::string16& title) = 0;

// Converts the icon into one that can be used on the Android Home screen.

+ // |generated| is an out-param that indicates whether the icon was

+ // generated by Chrome.

virtual SkBitmap FinalizeLauncherIcon(const SkBitmap& icon,

- const GURL& url) = 0;

+ const GURL& url,

+ bool* generated) = 0;

// Called when all the data needed to create a shortcut is available.

virtual void OnDataAvailable(const ShortcutInfo& info,

@@ -95,7 +98,7 @@ class AddToHomescreenDataFetcher

void OnManifestIconFetched(const SkBitmap& icon);

// Notifies the observer that the shortcut data is all available.

- void NotifyObserver(const SkBitmap& icon);

+ void NotifyObserver(const SkBitmap& icon, bool generated);

Observer* weak_observer_;