Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420723009: AppCache: Remove dead code from AppCacheService (Closed)

Created:
5 years, 1 month ago by nhiroki
Modified:
5 years, 1 month ago
Reviewers:
michaeln, kinuko
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppCache: Remove dead code from AppCacheService BUG=n/a Committed: https://crrev.com/6cefe7a880f30de1a5c16847c6ccc9621f41ab29 Cr-Commit-Position: refs/heads/master@{#357031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M content/browser/appcache/appcache_service_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/appcache/appcache_service_impl.cc View 2 chunks +0 lines, -57 lines 0 comments Download
M content/public/browser/appcache_service.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
nhiroki
PTAL, thanks!
5 years, 1 month ago (2015-10-29 09:00:29 UTC) #2
michaeln
lgtm (ty!)
5 years, 1 month ago (2015-10-29 18:57:00 UTC) #3
nhiroki
+kinuko@ for content/public/, ptal
5 years, 1 month ago (2015-10-29 23:37:45 UTC) #5
kinuko
lgtm
5 years, 1 month ago (2015-10-30 02:22:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420723009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420723009/1
5 years, 1 month ago (2015-10-30 02:30:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 02:37:10 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 02:38:35 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6cefe7a880f30de1a5c16847c6ccc9621f41ab29
Cr-Commit-Position: refs/heads/master@{#357031}

Powered by Google App Engine
This is Rietveld 408576698