Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420713006: Revert "EDK: Move //mojo/edk/system/waitable_event* to edk/util." (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
jackson
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "EDK: Move //mojo/edk/system/waitable_event* to edk/util." This reverts commit c079879fb71164876098efae585c4adb37ca1315. This is a temporary revert. Mac doesn't have (a useful) clock_gettime(). TBR=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/dd010e1297c09b351dc82f7def154cfa63d795b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -714 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/edk/system/master_connection_manager.h View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/test/test_io_thread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/test/test_io_thread.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + mojo/edk/system/waitable_event.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/edk/system/waitable_event.cc View 7 chunks +17 lines, -31 lines 0 comments Download
A + mojo/edk/system/waitable_event_unittest.cc View 15 chunks +23 lines, -31 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/edk/util/cond_var_unittest.cc View 7 chunks +10 lines, -13 lines 0 comments Download
M mojo/edk/util/mutex_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/edk/util/ref_counted_perftest.cc View 3 chunks +8 lines, -11 lines 0 comments Download
D mojo/edk/util/waitable_event.h View 1 chunk +0 lines, -127 lines 0 comments Download
D mojo/edk/util/waitable_event.cc View 1 chunk +0 lines, -182 lines 0 comments Download
D mojo/edk/util/waitable_event_unittest.cc View 1 chunk +0 lines, -265 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
5 years, 1 month ago (2015-11-06 22:12:04 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dd010e1297c09b351dc82f7def154cfa63d795b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698