src/js/harmony-array.js - Issue 1420663003: Avoid calling %AddElement with a number out of array index range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/harmony-array.js

Issue 1420663003: Avoid calling %AddElement with a number out of array index range (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix naming Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/harmony-array.js

diff --git a/src/js/harmony-array.js b/src/js/harmony-array.js

index d100c0dbea4d17b5638639f9d519a70250030ab8..20e5e78205cfa98608e68b6b38a347f7ca203170 100644

--- a/src/js/harmony-array.js

+++ b/src/js/harmony-array.js

@@ -11,6 +11,7 @@

// -------------------------------------------------------------------

// Imports

+var AddIndexedProperty;

var FLAG_harmony_tolength;

var GetIterator;

var GetMethod;

@@ -23,6 +24,7 @@ var ObjectIsFrozen;

var ObjectDefineProperty;

utils.Import(function(from) {

+ AddIndexedProperty = from.AddIndexedProperty;

FLAG_harmony_tolength = from.FLAG_harmony_tolength;

GetIterator = from.GetIterator;

GetMethod = from.GetMethod;

@@ -182,7 +184,7 @@ function ArrayFill(value, start, end) {

function AddArrayElement(constructor, array, i, value) {

if (constructor === GlobalArray) {

- %AddElement(array, i, value);

+ AddIndexedProperty(array, i, value);

} else {

ObjectDefineProperty(array, i, {

value: value, writable: true, configurable: true, enumerable: true

« no previous file with comments | « src/js/array.js ('k') | src/js/runtime.js » ('j') | src/js/runtime.js » ('J')