Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1420613008: Remove deprecated API usage from test-accessors. (Closed)

Created:
5 years, 1 month ago by vogelheim
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecated API usage from test-accessors. BUG= Committed: https://crrev.com/bf81c494a4370ff56e0cc168f5aa19d745a4356d Cr-Commit-Position: refs/heads/master@{#31628}

Patch Set 1 #

Patch Set 2 : De-uglify + remove unused x_context var. #

Total comments: 2

Patch Set 3 : Two lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -154 lines) Patch
M test/cctest/test-accessors.cc View 1 2 23 chunks +246 lines, -154 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vogelheim
5 years, 1 month ago (2015-10-28 10:33:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1420613008/diff/20001/test/cctest/test-accessors.cc File test/cctest/test-accessors.cc (left): https://codereview.chromium.org/1420613008/diff/20001/test/cctest/test-accessors.cc#oldcode101 test/cctest/test-accessors.cc:101: Nit. Keep two empty lives
5 years, 1 month ago (2015-10-28 10:58:21 UTC) #3
vogelheim
https://codereview.chromium.org/1420613008/diff/20001/test/cctest/test-accessors.cc File test/cctest/test-accessors.cc (left): https://codereview.chromium.org/1420613008/diff/20001/test/cctest/test-accessors.cc#oldcode101 test/cctest/test-accessors.cc:101: On 2015/10/28 10:58:20, jochen wrote: > Nit. Keep two ...
5 years, 1 month ago (2015-10-28 11:53:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420613008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420613008/40001
5 years, 1 month ago (2015-10-28 11:53:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-28 12:31:44 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 12:32:23 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf81c494a4370ff56e0cc168f5aa19d745a4356d
Cr-Commit-Position: refs/heads/master@{#31628}

Powered by Google App Engine
This is Rietveld 408576698