Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html

Issue 1420593005: Remove [TreatNullAs=NullString] from the 'dir' attribute on Document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/document-dir-property-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html b/third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html
index fce0786e48998b2a6584204d2962ef9e66fe7cfa..5114c8a9eb7f8e883edb8bbafc62a688b3e8701d 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/document-dir-property.html
@@ -28,6 +28,10 @@ debug("Read document.documentElement.dir in body");
shouldBeEqualToString("document.documentElement.dir", "rtl");
debug("");
+debug("Read document.documentElement.getAttribute('dir') in body");
+shouldBeEqualToString("document.documentElement.getAttribute('dir')", "rtl");
+debug("");
+
debug("Read document.body.dir in body");
shouldBeEqualToString("document.body.dir", "");
debug("");
@@ -45,6 +49,10 @@ debug("Read document.body.dir in body");
shouldBeEqualToString("document.body.dir", "");
debug("");
+debug("Read document.documentElement.getAttribute('dir') in body");
+shouldBeEqualToString("document.documentElement.getAttribute('dir')", "ltr");
+debug("");
+
debug("Write non-canonical case document.dir in body");
shouldNotThrow("document.dir = 'RTL'");
philipj_slow 2015/11/03 11:00:23 After this and the WRONG case, test that the conte
tanay.c 2015/11/03 11:32:58 Done.
shouldBeEqualToString("document.dir", "rtl");
@@ -64,6 +72,16 @@ debug("Write invalid document.body.dir in body");
shouldNotThrow("document.body.dir = 'WRONG'");
shouldBeEqualToString("document.body.dir", "");
debug("");
+
+document.dir = null;
+debug("Read document.dir in body");
+shouldBeEqualToString("document.dir", "");
+debug("");
+
+debug("Read document.documentElement.getAttribute('dir') in body");
+shouldBeEqualToString("document.documentElement.getAttribute('dir')", "null");
+debug("");
+
</script>
</body>
</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/document-dir-property-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698