fpdfsdk/src/fsdk_mgr.cpp - Issue 1420583003: Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_mgr.cpp

Issue 1420583003: Revert "Revert "Add type cast definitions for CPDF_Dictionary."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fsdk_mgr.cpp

diff --git a/fpdfsdk/src/fsdk_mgr.cpp b/fpdfsdk/src/fsdk_mgr.cpp

index 883ad60a93015c52550d33b4051cb9ba89a9c9fb..4cf05a2d79d35ee4a15f047a4531c8b7e53c40a7 100644

--- a/fpdfsdk/src/fsdk_mgr.cpp

+++ b/fpdfsdk/src/fsdk_mgr.cpp

@@ -480,8 +480,7 @@ FX_BOOL CPDFSDK_Document::ProcOpenAction() {

if (pOpenAction->GetType() == PDFOBJ_ARRAY)

return TRUE;

- if (pOpenAction->GetType() == PDFOBJ_DICTIONARY) {

- CPDF_Dictionary* pDict = (CPDF_Dictionary*)pOpenAction;

+ if (CPDF_Dictionary* pDict = pOpenAction->AsDictionary()) {

CPDF_Action action(pDict);

if (m_pEnv->GetActionHander())

m_pEnv->GetActionHander()->DoAction_DocOpen(action, this);

« no previous file with comments | « fpdfsdk/src/fsdk_baseform.cpp ('k') | no next file » | no next file with comments »