core/src/fpdftext/fpdf_text_int.cpp - Issue 1420583003: Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdftext/fpdf_text_int.cpp

Issue 1420583003: Revert "Revert "Add type cast definitions for CPDF_Dictionary."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdftext/fpdf_text_int.cpp

diff --git a/core/src/fpdftext/fpdf_text_int.cpp b/core/src/fpdftext/fpdf_text_int.cpp

index 906554dde2eaac5bfa6a26008dfb3e87c3ec3246..99f36a08585e1002e74ff4f82eda544f6899e8d0 100644

--- a/core/src/fpdftext/fpdf_text_int.cpp

+++ b/core/src/fpdftext/fpdf_text_int.cpp

@@ -1286,7 +1286,7 @@ int32_t CPDF_TextPage::PreMarkedContent(PDFTEXT_Obj Obj) {

for (n = 0; n < nContentMark; n++) {

CPDF_ContentMarkItem& item = pMarkData->GetItem(n);

CFX_ByteString tagStr = (CFX_ByteString)item.GetName();

- pDict = (CPDF_Dictionary*)item.GetParam();

+ pDict = ToDictionary(static_cast<CPDF_Object*>(item.GetParam()));

CPDF_String* temp =

(CPDF_String*)(pDict ? pDict->GetElement(FX_BSTRC("ActualText"))

: NULL);

@@ -1357,7 +1357,7 @@ void CPDF_TextPage::ProcessMarkedContent(PDFTEXT_Obj Obj) {