core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp - Issue 1420583003: Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

Issue 1420583003: Revert "Revert "Add type cast definitions for CPDF_Dictionary."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

index 63454d2cb5013d0681fb49a1bc157f24114276b9..c34d8122f8671e1a6b1f93a304e3eb672f5365b9 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

@@ -403,7 +403,7 @@ CFX_ByteTextBuf& operator<<(CFX_ByteTextBuf& buf, const CPDF_Object* pObj) {

break;

}

case PDFOBJ_DICTIONARY: {

- CPDF_Dictionary* p = (CPDF_Dictionary*)pObj;

+ const CPDF_Dictionary* p = pObj->AsDictionary();

buf << FX_BSTRC("<<");

FX_POSITION pos = p->GetStartPos();

while (pos) {

« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp ('k') | core/src/fpdfapi/fpdf_render/fpdf_render.cpp » ('j') | no next file with comments »