Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

core/src/fpdfdoc/doc_basic.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 const int nMaxRecursion = 32;
 int CPDF_Dest::GetPageIndex(CPDF_Document* pDoc) {
   if (m_pObj == NULL || m_pObj->GetType() != PDFOBJ_ARRAY) {
     return 0;
   }
   CPDF_Object* pPage = ((CPDF_Array*)m_pObj)->GetElementValue(0);
   if (pPage == NULL) {
     return 0;
   }
   if (pPage->GetType() == PDFOBJ_NUMBER) {
     return pPage->GetInteger();
   }
-  if (pPage->GetType() != PDFOBJ_DICTIONARY) {
+  if (!pPage->IsDictionary()) {
     return 0;
   }
   return pDoc->GetPageIndex(pPage->GetObjNum());
 }
 FX_DWORD CPDF_Dest::GetPageObjNum() {
   if (m_pObj == NULL || m_pObj->GetType() != PDFOBJ_ARRAY) {
     return 0;
   }
   CPDF_Object* pPage = ((CPDF_Array*)m_pObj)->GetElementValue(0);
   if (pPage == NULL) {
     return 0;
   }
   if (pPage->GetType() == PDFOBJ_NUMBER) {
     return pPage->GetInteger();
   }
-  if (pPage->GetType() == PDFOBJ_DICTIONARY) {
+  if (pPage->IsDictionary()) {
     return pPage->GetObjNum();
   }
   return 0;
 }
 const FX_CHAR* g_sZoomModes[] = {"XYZ",  "Fit",   "FitH",  "FitV", "FitR",
                                  "FitB", "FitBH", "FitBV", ""};
 int CPDF_Dest::GetZoomMode() {
   if (m_pObj == NULL || m_pObj->GetType() != PDFOBJ_ARRAY) {
     return 0;
   }
@@ skipping 189 matching lines @@
       return NULL;
     }
     pValue = pDests->GetElementValue(sName);
   }
   if (pValue == NULL) {
     return NULL;
   }
   if (pValue->GetType() == PDFOBJ_ARRAY) {
     return (CPDF_Array*)pValue;
   }
-  if (pValue->GetType() == PDFOBJ_DICTIONARY) {
-    return ((CPDF_Dictionary*)pValue)->GetArray(FX_BSTRC("D"));
+  if (CPDF_Dictionary* pDict = pValue->AsDictionary()) {
+    return pDict->GetArray(FX_BSTRC("D"));
   }
   return NULL;
 }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ || \
     _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
 static CFX_WideString ChangeSlashToPlatform(const FX_WCHAR* str) {
   CFX_WideString result;
   while (*str) {
     if (*str == '/') {
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
@@ skipping 46 matching lines @@
   }
   CFX_WideString result;
   result += '\\';
   result += ChangeSlashToPlatform(filepath.GetPtr());
   return result;
 #else
   return filepath;
 #endif
 }
 FX_BOOL CPDF_FileSpec::GetFileName(CFX_WideString& csFileName) const {
-  if (m_pObj == NULL) {
+  if (!m_pObj) {
     return FALSE;
   }
-  if (m_pObj->GetType() == PDFOBJ_DICTIONARY) {
-    CPDF_Dictionary* pDict = (CPDF_Dictionary*)m_pObj;
+  if (CPDF_Dictionary* pDict = m_pObj->AsDictionary()) {
     csFileName = pDict->GetUnicodeText(FX_BSTRC("UF"));
     if (csFileName.IsEmpty()) {
       csFileName = CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("F")));
     }
     if (pDict->GetString(FX_BSTRC("FS")) == FX_BSTRC("URL")) {
       return TRUE;
     }
     if (csFileName.IsEmpty()) {
       if (pDict->KeyExist(FX_BSTRC("DOS"))) {
         csFileName =
             CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("DOS")));
       } else if (pDict->KeyExist(FX_BSTRC("Mac"))) {
         csFileName =
             CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("Mac")));
       } else if (pDict->KeyExist(FX_BSTRC("Unix"))) {
         csFileName =
             CFX_WideString::FromLocal(pDict->GetString(FX_BSTRC("Unix")));
       } else {
         return FALSE;
       }
     }
   } else {
     csFileName = CFX_WideString::FromLocal(m_pObj->GetString());
   }
   csFileName = FILESPEC_DecodeFileName(csFileName);
   return TRUE;
 }
 CPDF_FileSpec::CPDF_FileSpec() {
   m_pObj = CPDF_Dictionary::Create();
-  if (m_pObj != NULL) {
-    ((CPDF_Dictionary*)m_pObj)
-        ->SetAtName(FX_BSTRC("Type"), FX_BSTRC("Filespec"));
+  if (CPDF_Dictionary* pDict = ToDictionary(m_pObj)) {
+    pDict->SetAtName(FX_BSTRC("Type"), FX_BSTRC("Filespec"));
   }
 }
 FX_BOOL CPDF_FileSpec::IsURL() const {
-  if (m_pObj == NULL) {
-    return FALSE;
+  if (CPDF_Dictionary* pDict = ToDictionary(m_pObj)) {
+    return pDict->GetString(FX_BSTRC("FS")) == FX_BSTRC("URL");
   }
-  if (m_pObj->GetType() != PDFOBJ_DICTIONARY) {
-    return FALSE;
-  }
-  return ((CPDF_Dictionary*)m_pObj)->GetString(FX_BSTRC("FS")) ==
-         FX_BSTRC("URL");
+  return FALSE;
 }
 CFX_WideString FILESPEC_EncodeFileName(const CFX_WideStringC& filepath) {
   if (filepath.GetLength() <= 1) {
     return CFX_WideString();
   }
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_
   if (filepath.GetAt(1) == ':') {
     CFX_WideString result;
     result = '/';
     result += filepath.GetAt(0);
@@ skipping 23 matching lines @@
   return ChangeSlashToPDF(filepath.GetPtr());
 #else
   return filepath;
 #endif
 }
 CPDF_Stream* CPDF_FileSpec::GetFileStream() const {
   if (m_pObj == NULL) {
     return NULL;
   }
   int32_t iType = m_pObj->GetType();
-  if (iType == PDFOBJ_STREAM) {
+  if (iType == PDFOBJ_STREAM)
     return (CPDF_Stream*)m_pObj;
-  } else if (iType == PDFOBJ_DICTIONARY) {
-    CPDF_Dictionary* pEF = ((CPDF_Dictionary*)m_pObj)->GetDict(FX_BSTRC("EF"));
-    if (pEF == NULL) {
-      return NULL;
-    }
+  if (CPDF_Dictionary* pEF = m_pObj->AsDictionary()->GetDict(FX_BSTRC("EF")))
     return pEF->GetStream(FX_BSTRC("F"));
-  }
   return NULL;
 }
 static void FPDFDOC_FILESPEC_SetFileName(CPDF_Object* pObj,
                                          const CFX_WideStringC& wsFileName,
                                          FX_BOOL bURL) {
   ASSERT(pObj != NULL);
   CFX_WideString wsStr;
   if (bURL) {
     wsStr = wsFileName;
   } else {
     wsStr = FILESPEC_EncodeFileName(wsFileName);
   }
   int32_t iType = pObj->GetType();
   if (iType == PDFOBJ_STRING) {
     pObj->SetString(CFX_ByteString::FromUnicode(wsStr));
-  } else if (iType == PDFOBJ_DICTIONARY) {
-    CPDF_Dictionary* pDict = (CPDF_Dictionary*)pObj;
+  } else if (CPDF_Dictionary* pDict = pObj->AsDictionary()) {
     pDict->SetAtString(FX_BSTRC("F"), CFX_ByteString::FromUnicode(wsStr));
     pDict->SetAtString(FX_BSTRC("UF"), PDF_EncodeText(wsStr));
   }
 }
 void CPDF_FileSpec::SetFileName(const CFX_WideStringC& wsFileName,
                                 FX_BOOL bURL) {
   ASSERT(m_pObj != NULL);
-  if (m_pObj->GetType() == PDFOBJ_DICTIONARY && bURL) {
-    ((CPDF_Dictionary*)m_pObj)->SetAtName(FX_BSTRC("FS"), "URL");
+  if (bURL) {
+    if (CPDF_Dictionary* pDict = m_pObj->AsDictionary()) {
+      pDict->SetAtName(FX_BSTRC("FS"), "URL");
+    }
   }
   FPDFDOC_FILESPEC_SetFileName(m_pObj, wsFileName, bURL);
 }
 static CFX_WideString _MakeRoman(int num) {
   const int arabic[] = {1000, 900, 500, 400, 100, 90, 50, 40, 10, 9, 5, 4, 1};
   const CFX_WideString roman[] = {L"m",  L"cm", L"d",  L"cd", L"c",
                                   L"xc", L"l",  L"xl", L"x",  L"ix",
                                   L"v",  L"iv", L"i"};
   const int nMaxNum = 1000000;
   num %= nMaxNum;
@@ skipping 60 matching lines @@
   int n = nPage;
   while (n >= 0) {
     pValue = numberTree.LookupValue(n);
     if (pValue != NULL) {
       break;
     }
     n--;
   }
   if (pValue != NULL) {
     pValue = pValue->GetDirect();
-    if (pValue->GetType() == PDFOBJ_DICTIONARY) {
-      CPDF_Dictionary* pLabel = (CPDF_Dictionary*)pValue;
+    if (CPDF_Dictionary* pLabel = pValue->AsDictionary()) {
       if (pLabel->KeyExist(FX_BSTRC("P"))) {
         wsLabel += pLabel->GetUnicodeText(FX_BSTRC("P"));
       }
       CFX_ByteString bsNumberingStyle = pLabel->GetString(FX_BSTRC("S"), NULL);
       int nLabelNum = nPage - n + pLabel->GetInteger(FX_BSTRC("St"), 1);
       CFX_WideString wsNumPortion =
           _GetLabelNumPortion(nLabelNum, bsNumberingStyle);
       wsLabel += wsNumPortion;
       return wsLabel;
     }
@@ skipping 22 matching lines @@
   int nPage = FXSYS_atoi(bsLbl);
   if (nPage > 0 && nPage <= nPages) {
     return nPage;
   }
   return -1;
 }
 int32_t CPDF_PageLabel::GetPageByLabel(const CFX_WideStringC& wsLabel) const {
   CFX_ByteString bsLabel = PDF_EncodeText(wsLabel.GetPtr());
   return GetPageByLabel(bsLabel);
 }