Revert "Revert "Add type cast definitions for CPDF_Dictionary.""

core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_parser.h"
 #include "../../../include/fpdfapi/fpdf_module.h"
 
 
@@ skipping 125 matching lines @@
     }
   }
   return NULL;
 }
 
 CPDF_Dictionary* CPDF_Document::GetPage(int iPage) {
   if (iPage < 0 || iPage >= m_PageList.GetSize())
     return nullptr;
 
   if (m_bLinearized && (iPage == (int)m_dwFirstPageNo)) {
-    CPDF_Object* pObj = GetIndirectObject(m_dwFirstPageObjNum);
-    if (pObj && pObj->GetType() == PDFOBJ_DICTIONARY) {
-      return static_cast<CPDF_Dictionary*>(pObj);
-    }
+    if (CPDF_Dictionary* pDict =
+            ToDictionary(GetIndirectObject(m_dwFirstPageObjNum)))
+      return pDict;
   }
 
   int objnum = m_PageList.GetAt(iPage);
   if (objnum) {
-    CPDF_Object* pObj = GetIndirectObject(objnum);
-    if (pObj && pObj->GetType() == PDFOBJ_DICTIONARY) {
-      return static_cast<CPDF_Dictionary*>(pObj);
-    }
+    if (CPDF_Dictionary* pDict = ToDictionary(GetIndirectObject(objnum)))
+      return pDict;
   }
 
   CPDF_Dictionary* pRoot = GetRoot();
   if (!pRoot)
     return nullptr;
 
   CPDF_Dictionary* pPages = pRoot->GetDict(FX_BSTRC("Pages"));
   if (!pPages)
     return nullptr;
 
@@ skipping 189 matching lines @@
 void CPDF_Document::ClearPageData() {
   if (m_pDocPage) {
     CPDF_ModuleMgr::Get()->GetPageModule()->ClearDoc(this);
   }
 }
 void CPDF_Document::ClearRenderData() {
   if (m_pDocRender) {
     CPDF_ModuleMgr::Get()->GetRenderModule()->ClearDocData(m_pDocRender);
   }
 }