Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1420573002: [turbofan] Fix liveness analysis for let variable in TDZ. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix liveness analysis for let variable in TDZ. This makes sure that initializing assignments of let-declared variables perform an environment lookup and hence keep the variable alive. This is needed because full-codegen contains debug code verifying the variable is still inside the TDZ at the initializing assignment. R=jarin@chromium.org TEST=mjsunit/compiler/regress-variable-liveness-let BUG=v8:4493 LOG=n Committed: https://crrev.com/d9a5add017d732ee9a536f85fe7abd9450f99215 Cr-Commit-Position: refs/heads/master@{#31437}

Patch Set 1 #

Patch Set 2 : Small fix. #

Patch Set 3 : Relax check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-variable-liveness-let.js View 1 chunk +5 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-20 16:56:26 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-21 11:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420573002/40001
5 years, 2 months ago (2015-10-21 12:21:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-21 12:22:53 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 12:23:12 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9a5add017d732ee9a536f85fe7abd9450f99215
Cr-Commit-Position: refs/heads/master@{#31437}

Powered by Google App Engine
This is Rietveld 408576698