third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h - Issue 1420553004: SVG Web Animations: Add compositing pipeline for SVGInterpolationTypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

Issue 1420553004: SVG Web Animations: Add compositing pipeline for SVGInterpolationTypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgValueInterpolationType

Patch Set: Rebased Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SampledEffect.cpp ('k') | third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

diff --git a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

index f7168c6f4fb87c6ce45f8b2fb67e5206de4bd1b7..3cbf61eeb702c66ab1a6b5d82ac5354c9819496d 100644

--- a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

+++ b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

@@ -35,6 +35,7 @@ class Document;

class LayoutSVGResourceContainer;

class SubtreeLayoutScope;

class SVGSVGElement;

+class SVGElement;

class Element;

class SVGDocumentExtensions : public NoBaseWillBeGarbageCollectedFinalized<SVGDocumentExtensions> {

@@ -47,6 +48,9 @@ public:

void addTimeContainer(SVGSVGElement*);

void removeTimeContainer(SVGSVGElement*);

+ // Records the SVG element as having a Web Animation on an SVG attribute that needs applying.

+ void addPendingWebAnimatedSVGElement(SVGElement&);

dstockwell 2015/10/28 03:39:38 nit. pending what? I'd suggest something like: add

alancutter (OOO until 2018) 2015/10/29 04:56:51 Done. Named as addWebAnimationsPendingSVGElement()

void addResource(const AtomicString& id, LayoutSVGResourceContainer*);

void removeResource(const AtomicString& id);

LayoutSVGResourceContainer* resourceById(const AtomicString& id) const;

@@ -80,6 +84,8 @@ public:

private:

RawPtrWillBeMember<Document> m_document;

WillBeHeapHashSet<RawPtrWillBeMember<SVGSVGElement>> m_timeContainers; // For SVG 1.2 support this will need to be made more general.

+ using SVGElementSet = WillBeHeapHashSet<RefPtrWillBeMember<SVGElement>>;

+ SVGElementSet m_webAnimatedSVGElements;

HashMap<AtomicString, LayoutSVGResourceContainer*> m_resources;

WillBeHeapHashMap<AtomicString, OwnPtrWillBeMember<SVGPendingElements>> m_pendingResources; // Resources that are pending.

WillBeHeapHashMap<AtomicString, OwnPtrWillBeMember<SVGPendingElements>> m_pendingResourcesForRemoval; // Resources that are pending and scheduled for removal.