Chromium Code Reviews

Issue 1420543003: [x64] Implement vsqrtsd AVX instruction. (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Implement vsqrtsd AVX instruction. BUG=v8:4406 LOG=N Committed: https://crrev.com/7ae54d2b82a283d06c0b60a1268fcf5136da6eca Cr-Commit-Position: refs/heads/master@{#31490}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+54 lines, -6 lines)
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +3 lines, -3 lines 0 comments
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments
M src/x64/assembler-x64.cc View 2 chunks +2 lines, -0 lines 0 comments
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/x64/codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments
M src/x64/disasm-x64.cc View 1 chunk +5 lines, -0 lines 0 comments
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments
M src/x64/macro-assembler-x64.cc View 1 chunk +20 lines, -0 lines 0 comments
M test/cctest/test-assembler-x64.cc View 1 chunk +15 lines, -0 lines 0 comments
M test/cctest/test-disasm-x64.cc View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 7 (2 generated)
alph
5 years, 2 months ago (2015-10-22 21:43:02 UTC) #2
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-23 04:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420543003/1
5 years, 2 months ago (2015-10-23 06:26:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 06:47:17 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 06:47:56 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ae54d2b82a283d06c0b60a1268fcf5136da6eca
Cr-Commit-Position: refs/heads/master@{#31490}

Powered by Google App Engine