Issue 1420533012: EDK: Make mojo::embedder::AsyncWait (etc.) take an std::function instead of a base::Callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1420533012: EDK: Make mojo::embedder::AsyncWait (etc.) take an std::function instead of a base::Callback. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Make mojo::embedder::AsyncWait (etc.) take an std::function instead of a base::Callback. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/de5aba4ae7e0b3f569b9199ff7c1723690c0d839

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -23 lines)			Patch
M	mojo/edk/embedder/embedder.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/embedder/embedder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/embedder/embedder_unittest.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	mojo/edk/system/async_waiter.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/system/async_waiter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/core.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/system/core.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/core_unittest.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-11-11 01:06:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de5aba4ae7e0b3f569b9199ff7c1723690c0d839 (presubmit successful).

Expand Messages | Collapse Messages