content/common/gpu/gpu_command_buffer_stub.h - Issue 1420533009: Cleanup GpuMemoryManager and helpers.

Unified Diff: content/common/gpu/gpu_command_buffer_stub.h

Issue 1420533009: Cleanup GpuMemoryManager and helpers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/gpu_command_buffer_stub.h

diff --git a/content/common/gpu/gpu_command_buffer_stub.h b/content/common/gpu/gpu_command_buffer_stub.h

index 0537c30283581f5a4216433603f0f166cb0eaa61..be4c5a032772fe280a25057e84d5367dd2d16d10 100644

--- a/content/common/gpu/gpu_command_buffer_stub.h

+++ b/content/common/gpu/gpu_command_buffer_stub.h

@@ -14,7 +14,6 @@

#include "base/time/time.h"

#include "content/common/content_export.h"

#include "content/common/gpu/gpu_memory_manager.h"

-#include "content/common/gpu/gpu_memory_manager_client.h"

#include "gpu/command_buffer/common/constants.h"

#include "gpu/command_buffer/common/gpu_memory_allocation.h"

#include "gpu/command_buffer/service/command_buffer_service.h"

@@ -55,8 +54,7 @@ class GpuWatchdog;

struct WaitForCommandState;

class GpuCommandBufferStub

- : public GpuMemoryManagerClient,

- public IPC::Listener,

+ : public IPC::Listener,

public IPC::Sender,

public base::SupportsWeakPtr<GpuCommandBufferStub> {

public:

@@ -100,11 +98,10 @@ class GpuCommandBufferStub

// IPC::Sender implementation:

bool Send(IPC::Message* msg) override;

- // GpuMemoryManagerClient implementation:

- gfx::Size GetSurfaceSize() const override;

- gpu::gles2::MemoryTracker* GetMemoryTracker() const override;

- void SuggestHaveFrontBuffer(bool suggest_have_frontbuffer) override;

- bool GetTotalGpuMemory(uint64* bytes) override;

+ gfx::Size GetSurfaceSize() const;

piman 2015/11/10 23:34:48 This doesn't look like it's called any more. Remov

sohanjg 2015/11/13 07:30:44 Done.

+ gpu::gles2::MemoryTracker* GetMemoryTracker() const;

+ void SuggestHaveFrontBuffer(bool suggest_have_frontbuffer);

piman 2015/11/10 23:34:49 Same here.

sohanjg 2015/11/13 07:30:44 Done.

+ bool GetTotalGpuMemory(uint64* bytes);

piman 2015/11/10 23:34:48 Same here, and can remove total_gpu_memory_. I th

sohanjg 2015/11/13 07:30:44 Done.

// Whether this command buffer can currently handle IPC messages.

bool IsScheduled();

« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_memory_manager.h » ('j') | content/common/gpu/gpu_memory_manager.h » ('J')