Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1420533006: Allow for multiple rounds of precompilation. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : land with one round #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -17 lines) Patch
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 5 chunks +69 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 1 month ago (2015-10-29 20:07:16 UTC) #2
Florian Schneider
lgtm
5 years, 1 month ago (2015-10-29 20:56:52 UTC) #3
rmacnak
5 years, 1 month ago (2015-10-29 21:25:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7cacbff77b58c41a10f8dcf3fa16dd2a833f17bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698