Mac: Kill lots of AcceleratedWidget code (with fire)

ui/views/widget/native_widget_mac_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/widget/native_widget_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/foundation_util.h"
 #import "base/mac/scoped_nsobject.h"
@@ skipping 47 matching lines @@
 // BridgedNativeWidget friend to access private members.
 class BridgedNativeWidgetTestApi {
  public:
   explicit BridgedNativeWidgetTestApi(NSWindow* window) {
     bridge_ = NativeWidgetMac::GetBridgeForNativeWindow(window);
   }
 
   // Simulate a frame swap from the compositor. Assumes scale factor of 1.0f.
   void SimulateFrameSwap(const gfx::Size& size) {
     const float kScaleFactor = 1.0f;
-    SkBitmap bitmap;
-    bitmap.allocN32Pixels(size.width(), size.height());
-    SkCanvas canvas(bitmap);
-    bridge_->compositor_widget_->GotSoftwareFrame(kScaleFactor, &canvas);
+    bridge_->compositor_widget_->GotIOSurfaceFrame(
+        base::ScopedCFTypeRef<IOSurfaceRef>(),
+        size,
+        kScaleFactor,
+        false);

[tapted, 2015/10/26 02:51:42]

Sadly the NativeWidgetMacTest.InvalidateShadow views_unittest fails with only
this (sorry - haven't yet made views_unittests part of the required tryjob
tasks). 

The problem is that previously AcceleratedWidgetMac::GotSoftwareFrame() would
update AcceleratedWidgetMac::last_swap_size_dip_ but now that only happens via
AcceleratedWidgetMac::GotAcceleratedFrame()

Maybe last_swap_size_dip_ isn't really needed for software frames... in which
case it's just the test that's broken - i.e. SimulateFrameSwap should simulate
an accelerated frame rather than a software frame [although I couldn't figure
out how to make this work in a unit test when I first made this - it's probably
fine to leave the test failing until I can figure it out]

But if last_swap_size_dip_ _should_ be updated for software frames then, one
option: the line that updates it in GotAcceleratedFrame() could be moved and
copied to GotAcceleratedCAContextFrame() and GotIOSurfaceFrame() [I've verified
that would fix the test]

[ccameron, 2015/10/26 06:40:34]

I went with the last solution -- yes, last_swap_size_dip_ should be updated.

     std::vector<ui::LatencyInfo> latency_info;
     bridge_->AcceleratedWidgetSwapCompleted(latency_info);
   }
 
  private:
   BridgedNativeWidget* bridge_;
 
   DISALLOW_COPY_AND_ASSIGN(BridgedNativeWidgetTestApi);
 };
 
@@ skipping 1021 matching lines @@
 @implementation NativeWidgetMacTestWindow
 
 @synthesize invalidateShadowCount = invalidateShadowCount_;
 
 - (void)invalidateShadow {
   ++invalidateShadowCount_;
   [super invalidateShadow];
 }
 
 @end