Mac: Kill lots of AcceleratedWidget code (with fire)

content/common/gpu/image_transport_surface_iosurface_mac.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/image_transport_surface_iosurface_mac.h"
 
 #include "content/common/gpu/gpu_messages.h"
 #include "ui/accelerated_widget_mac/surface_handle_types.h"
 
 namespace content {
 namespace {
 
 // IOSurface dimensions will be rounded up to a multiple of this value in order
 // to reduce memory thrashing during resize. This must be a power of 2.
-const uint32 kIOSurfaceDimensionRoundup = 64;
+const uint32 kIOSurfaceDimensionRoundup = 1;

[ccameron, 2015/10/22 06:09:28]

This is needed so that the IOSurface will always be the size of the content that
is intended to be drawn. This code is going to be destroyed in a follow-up CL,
and the regression in memory usage is limited to when people are rapidly
resizing windows on 10.6-10.8.

 
 int RoundUpSurfaceDimension(int number) {
   DCHECK(number >= 0);
   // Cast into unsigned space for portable bitwise ops.
   uint32 unsigned_number = static_cast<uint32>(number);
   uint32 roundup_sub_1 = kIOSurfaceDimensionRoundup - 1;
   unsigned_number = (unsigned_number + roundup_sub_1) & ~roundup_sub_1;
   return static_cast<int>(unsigned_number);
 }
 
@@ skipping 26 matching lines @@
 gfx::Size IOSurfaceStorageProvider::GetRoundedSize(gfx::Size size) {
   return gfx::Size(RoundUpSurfaceDimension(size.width()),
                    RoundUpSurfaceDimension(size.height()));
 }
 
 bool IOSurfaceStorageProvider::AllocateColorBufferStorage(
     CGLContextObj context, const base::Closure& context_dirtied_callback,
     GLuint texture, gfx::Size pixel_size, float scale_factor) {
   // Allocate a new IOSurface, which is the GPU resource that can be
   // shared across processes.
+  int pixel_format = 'BGRA';
   base::ScopedCFTypeRef<CFMutableDictionaryRef> properties;
   properties.reset(CFDictionaryCreateMutable(kCFAllocatorDefault,
                                              0,
                                              &kCFTypeDictionaryKeyCallBacks,
                                              &kCFTypeDictionaryValueCallBacks));
+  AddIntegerValue(properties, kIOSurfacePixelFormat, pixel_format);

[ccameron, 2015/10/22 06:09:28]

This property is needed for -[CALayer setContents:] to work.

   AddIntegerValue(properties,
                   kIOSurfaceWidth,
                   pixel_size.width());
   AddIntegerValue(properties,
                   kIOSurfaceHeight,
                   pixel_size.height());
   AddIntegerValue(properties,
                   kIOSurfaceBytesPerElement, 4);
   AddBooleanValue(properties,
                   kIOSurfaceIsGlobal, true);
@@ skipping 55 matching lines @@
 void IOSurfaceStorageProvider::DiscardBackbuffer() {
 }
 
 void IOSurfaceStorageProvider::SwapBuffersAckedByBrowser(
     bool disable_throttling) {
   DCHECK(!pending_swapped_surfaces_.empty());
   pending_swapped_surfaces_.pop_front();
 }
 
 }  //  namespace content