Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1420503007: Improve the command line interface for perf dashboard upload. (Closed)

Created:
5 years, 2 months ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
vtl, etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve the command line interface for perf dashboard upload. This patch: - renames `perf_id` which really is bot name and ends up being the value for the "bot" field in the data being sent to `bot_name`. - adds an explicit `--upload` flag for perf test / benchmark runner (rather than making the upload call based on the collective presence of all optional upload parameters) R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ccaee11a5bfbed231753bc92e98cc2e5b1270a49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 5 chunks +9 lines, -6 lines 0 comments Download
M mojo/tools/get_test_list.py View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/tools/perf_test_runner.py View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ppi
Hi Etienne, ptal.
5 years, 2 months ago (2015-10-23 15:57:20 UTC) #3
ppi
+ Trung, as Etienne left for the weekend Trung, can you tal?
5 years, 2 months ago (2015-10-23 15:59:05 UTC) #5
etiennej
lgtm
5 years, 1 month ago (2015-10-26 08:03:37 UTC) #6
ppi
5 years, 1 month ago (2015-10-26 08:12:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ccaee11a5bfbed231753bc92e98cc2e5b1270a49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698