Issue 14205026: views: Cleanup BrowserView function order and variable names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14205026: views: Cleanup BrowserView function order and variable names (Closed)

Created:
7 years, 8 months ago by James Cook

Modified:
7 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Cleanup BrowserView function order and variable names Motivated by issues I had working in BrowserView and BrowserViewLayout: * Remove unnecessary virtual keyword and protected section, as this class has no subclasses. * Grouped overridden methods together. * Fixed function order in .cc file. * Renamed contents_container_ to contents_web_view_, as it is a WebView * Renamed contents_ to contents_container_, as it is a ContentsContainer BUG=232971 TEST=compiles, existing browser tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194999

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -113 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2	7 chunks	+37 lines, -40 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2	22 chunks	+72 lines, -71 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Cook

7 years, 8 months ago (2013-04-18 20:55:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r194999 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14205026: views: Cleanup BrowserView function order and variable names (Closed)

Description

Patch Set 1 #

Patch Set 2 : cleanup BrowserView #

Patch Set 3 : rebase #

Messages