Issue 9845. Compare runtime types using ==.

editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
index ba24e50015b57be9f882c3df2cb302450e99e78d..a294753fe59b290855d89060884b161f54e244ac 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
@@ -70,9 +70,6 @@ import com.google.dart.engine.scanner.TokenType;
 import com.google.dart.engine.source.Source;
 import com.google.dart.engine.utilities.io.PrintStringWriter;
 
-import java.io.PrintWriter;
-import java.io.StringWriter;
-
 /**
  * Instances of the class {@code DeclarationResolver} are used to resolve declarations in an AST
  * structure to already built elements.
@@ -210,9 +207,7 @@ public class DeclarationResolver extends RecursiveASTVisitor<Void> {
         writer.println("---------");
         parent = parent.getParent();
       }
-      StringWriter sw = new StringWriter();
-      new AnalysisException().printStackTrace(new PrintWriter(sw));
-      writer.println(sw.toString());
+      new AnalysisException().printStackTrace(writer);
       AnalysisEngine.getInstance().getLogger().logError(writer.toString());

[Brian Wilkerson, 2013/04/17 18:59:42]

Seems like it would be better still to just write

 ...logError(writer.toString(), new AnalysisException());

     }
     Expression defaultValue = node.getDefaultValue();