Issue 14205009: cc: Chromify gl_renderer_unittest.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14205009: cc: Chromify gl_renderer_unittest.cc. (Closed)

Created:
7 years, 8 months ago by reveman

Modified:
7 years, 8 months ago

Reviewers:
danakj

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Chromify gl_renderer_unittest.cc. Style-only change. R=danakj BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194650

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -127 lines)			Patch
	M	cc/output/gl_renderer_unittest.cc	View	1	19 chunks	+149 lines, -127 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danakj

LGTM w/ 1 nit https://codereview.chromium.org/14205009/diff/1/cc/output/gl_renderer_unittest.cc File cc/output/gl_renderer_unittest.cc (right): https://codereview.chromium.org/14205009/diff/1/cc/output/gl_renderer_unittest.cc#newcode277 cc/output/gl_renderer_unittest.cc:277: renderer_(GLRenderer::Create(&mock_client_, output_surface_.get(), nit: one argument ...

7 years, 8 months ago (2013-04-17 17:44:59 UTC) #2

reveman

https://codereview.chromium.org/14205009/diff/1/cc/output/gl_renderer_unittest.cc File cc/output/gl_renderer_unittest.cc (right): https://codereview.chromium.org/14205009/diff/1/cc/output/gl_renderer_unittest.cc#newcode277 cc/output/gl_renderer_unittest.cc:277: renderer_(GLRenderer::Create(&mock_client_, output_surface_.get(), On 2013/04/17 17:44:59, danakj wrote: > nit: ...

7 years, 8 months ago (2013-04-17 18:26:04 UTC) #3

reveman

7 years, 8 months ago (2013-04-17 18:59:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194650 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14205009: cc: Chromify gl_renderer_unittest.cc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages