Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420473003: [swarming] Isolate custom libcxx. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
M-A Ruel, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Isolate custom libcxx. BUG=chromium:535160 LOG=n Committed: https://crrev.com/fd0ee280485c8a2f8a7cc1f0754375cf9c71b952 Cr-Commit-Position: refs/heads/master@{#31612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/isolate.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/base.isolate View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL. This makes sanitizers work.
5 years, 1 month ago (2015-10-27 16:13:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420473003/1
5 years, 1 month ago (2015-10-27 16:14:07 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-27 16:24:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420473003/1
5 years, 1 month ago (2015-10-27 16:27:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 17:09:21 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 17:09:41 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd0ee280485c8a2f8a7cc1f0754375cf9c71b952
Cr-Commit-Position: refs/heads/master@{#31612}

Powered by Google App Engine
This is Rietveld 408576698