Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420473002: Move math-related typed arrays off js builtins object.. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move math-related typed arrays off js builtins object.. Committed: https://crrev.com/b0e4dce6091a8777bda80d962df76525dc6c5ea9 Cr-Commit-Position: refs/heads/master@{#31481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -41 lines) Patch
M src/bootstrapper.cc View 5 chunks +40 lines, -35 lines 0 comments Download
M src/js/math.js View 2 chunks +5 lines, -2 lines 0 comments Download
M src/js/prologue.js View 4 chunks +27 lines, -1 line 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
Please take a look.
5 years, 2 months ago (2015-10-20 04:31:00 UTC) #2
Camillo Bruni
lgtm
5 years, 2 months ago (2015-10-20 07:59:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420473002/1
5 years, 2 months ago (2015-10-22 13:38:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/9058) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 2 months ago (2015-10-22 13:39:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420473002/1
5 years, 2 months ago (2015-10-22 13:45:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 14:40:46 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 14:41:12 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b0e4dce6091a8777bda80d962df76525dc6c5ea9
Cr-Commit-Position: refs/heads/master@{#31481}

Powered by Google App Engine
This is Rietveld 408576698