Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1420433004: Move selector and arguments descriptor into MegamorphicCache. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: parne Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/service_ref.html ('k') | runtime/vm/megamorphic_cache_table.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index acb3edff8293467f95efff90b6d5c2789a60da22..9b5f7a2bd3b303fda0ab55a9cbe06b5e35bad54e 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -114,6 +114,7 @@ abstract class ServiceObject extends Observable {
String _vmType;
bool get isICData => vmType == 'ICData';
+ bool get isMegamorphicCache => vmType == 'MegamorphicCache';
bool get isInstructions => vmType == 'Instructions';
bool get isObjectPool => vmType == 'ObjectPool';
bool get isContext => type == 'Context';
@@ -3338,6 +3339,8 @@ class ICData extends HeapObject {
class MegamorphicCache extends HeapObject {
@observable int mask;
@observable Instance buckets;
+ @observable String selector;
+ @observable Instance argumentsDescriptor;
bool get canCache => false;
bool get immutable => false;
@@ -3348,12 +3351,14 @@ class MegamorphicCache extends HeapObject {
_upgradeCollection(map, isolate);
super._update(map, mapIsRef);
+ selector = map['_selector'];
if (mapIsRef) {
return;
}
mask = map['_mask'];
buckets = map['_buckets'];
+ argumentsDescriptor = map['_argumentsDescriptor'];
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/service_ref.html ('k') | runtime/vm/megamorphic_cache_table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698