Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 142043010: Modify the format output when a DOM-object leak is detected (Closed)

Created:
6 years, 10 months ago by hajimehoshi
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, haraken, kouhei (in TOK)
Visibility:
Public.

Description

Modify the format output when a DOM-object leak is detected Modifies the output to the following style: #LEAK renderer pid PID (DETAIL_IN_JSON_FORMAT) Now, this leaking output is not used anywhere, and this will be used by https://codereview.chromium.org/148153009/. See also: https://docs.google.com/a/chromium.org/document/d/1sFAsZxeISKnbGdXoLZlB2tDZ8pvO102ePFQx6TX4X14/edit BUG=332630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251310

Patch Set 1 #

Patch Set 2 : rebasing #

Patch Set 3 : Bug fix: a wrong hyphen in the message #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
content/shell/browser/webkit_test_controller.cc View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M content/shell/common/leak_detection_result.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/common/shell_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/leak_detector.cc View 2 chunks +27 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
+dpranke it would be good if you only uploaded the diff that corresponds to this ...
6 years, 10 months ago (2014-01-28 13:10:13 UTC) #1
hajimehoshi
> it would be good if you only uploaded the diff that corresponds to this ...
6 years, 10 months ago (2014-02-12 07:15:17 UTC) #2
Dirk Pranke
basically looks ok to me, but jochen should confirm.
6 years, 10 months ago (2014-02-12 21:09:28 UTC) #3
jochen (gone - plz use gerrit)
patch set #2 lgtm patch set 3 contains unrelated changes again?
6 years, 10 months ago (2014-02-13 09:26:08 UTC) #4
hajimehoshi
On 2014/02/13 09:26:08, jochen wrote: > patch set #2 lgtm > > patch set 3 ...
6 years, 10 months ago (2014-02-13 10:53:42 UTC) #5
hajimehoshi
The CQ bit was checked by hajimehoshi@chromium.org
6 years, 10 months ago (2014-02-14 05:15:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/142043010/190001
6 years, 10 months ago (2014-02-14 05:16:16 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:38:09 UTC) #8
Message was sent while issue was closed.
Change committed as 251310

Powered by Google App Engine
This is Rietveld 408576698