Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 142043004: Default to --nacl --arm in install-build-deps.sh (Closed)

Created:
6 years, 11 months ago by Roland McGrath
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Default to --nacl --arm in install-build-deps.sh These modes are needed on some bots, so make them the default to keep the bot-making procedure straightforward. R=bradnelson@google.com, iannucci@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245664

Patch Set 1 #

Patch Set 2 : just default to --nacl --arm instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/install-build-deps.sh View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Roland McGrath
6 years, 11 months ago (2014-01-17 23:12:37 UTC) #1
Sam Clegg
lgtm
6 years, 11 months ago (2014-01-17 23:19:08 UTC) #2
Roland McGrath
PTAL, especially infra folks. This is what we propose so that a simple run of ...
6 years, 11 months ago (2014-01-17 23:26:39 UTC) #3
bradn
lgtm
6 years, 11 months ago (2014-01-17 23:27:31 UTC) #4
iannucci
+phajdan lgtm, though, do we want to also get lib32? Or is that better left ...
6 years, 11 months ago (2014-01-17 23:52:58 UTC) #5
Roland McGrath
On 2014/01/17 23:52:58, iannucci wrote: > +phajdan > > lgtm, though, do we want to ...
6 years, 11 months ago (2014-01-17 23:56:53 UTC) #6
Roland McGrath
6 years, 11 months ago (2014-01-17 23:59:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r245664 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698