Remove some uninitialized reads from simple cache metadata serializer.

Remove some uninitialized reads from simple cache metadata serializer.

Valgrind detects uninitialized reads very well, and that's great! It catches cases when we allocate garbage on stack, hash it, write to the file. If we ever had wanted to repeat the operation, the hash would have been most likely be different, which could be fine in prod, but bad for testing.

More details in the bug.

BUG=173393
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193936

[gavinp, 2013-04-12 10:18:08]

Consider guarding SimpleFileHeader.

LGTM.

We should file a bug to not write structs to disk.

[felipeg, 2013-04-12 10:19:39]

On 2013/04/12 10:18:08, gavinp wrote:
> Consider guarding SimpleFileHeader.
> 
> LGTM.
> 
> We should file a bug to not write structs to disk.

LGTM
we should write C++ code from now on.
Use classes
and write our own hand-made serialize functions or use a protobuffer

[pasko-google - do not use, 2013-04-12 10:41:40]

On 2013/04/12 10:18:08, gavinp wrote:
> Consider guarding SimpleFileHeader.

uploaded some more

[gavinp, 2013-04-12 10:43:29]

LGTM.

Can you make the CL description a bit longer before CQ?

[pasko-google - do not use, 2013-04-12 10:54:29]

On 2013/04/12 10:43:29, gavinp wrote:
> LGTM.
> 
> Can you make the CL description a bit longer before CQ?

done

[commit-bot: I haz the power, 2013-04-12 10:54:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pasko@google.com/14204002/7001

[commit-bot: I haz the power, 2013-04-12 11:01:09]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-12 11:15:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pasko@google.com/14204002/7001

[commit-bot: I haz the power, 2013-04-12 11:27:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[pasko-google - do not use, 2013-04-12 14:46:19]

Committed patchset #2 manually as r193936 (presubmit successful).

[pasko-google - do not use, 2013-04-12 14:46:47]

On 2013/04/12 14:46:19, pasko wrote:
> Committed patchset #2 manually as r193936 (presubmit successful).

committed manually since it is blocking our testing