Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1420363005: Error Suppression FTW. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Typo. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index c84b5dd3fc15faee47b8ffa71b7ce173d3aee74b..38d095ab2ba07b5cfd0936372fcaf12057c075f3 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -764,7 +764,8 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
@override
- Object getConfigurationData(ResultDescriptor key) => _configurationData[key];
+ Object getConfigurationData(ResultDescriptor key) =>
+ _configurationData[key] ?? key?.defaultValue;
@override
TimestampedData<String> getContents(Source source) {
@@ -1023,10 +1024,14 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
/**
- * Invalidate analysis cache.
+ * Invalidate analysis cache and notify work managers that they have work
+ * to do.
*/
void invalidateCachedResults() {
_cache = createCacheFromSourceFactory(_sourceFactory);
+ for (WorkManager workManager in workManagers) {
+ workManager.onAnalysisOptionsChanged();
scheglov 2015/10/27 23:41:44 Maybe we should rename this method to reflect the
Brian Wilkerson 2015/10/28 02:09:08 Is that the only time it's used? (I actually prefe
pquitslund 2015/10/28 15:56:44 Maybe `invalidateResults` or something? It's pret
+ }
}
@override

Powered by Google App Engine
This is Rietveld 408576698