Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420363004: Remove special handling of background idle notification in memory reducer. (Closed)

Created:
5 years, 1 month ago by ulan
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove special handling of background idle notification in memory reducer. BUG=chromium:490559 LOG=NO Committed: https://crrev.com/7ac5af5c12685ba6f9d87c135d9acae3e077a2fe Cr-Commit-Position: refs/heads/master@{#31600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -88 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M src/heap/memory-reducer.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/heap/memory-reducer.cc View 5 chunks +5 lines, -38 lines 0 comments Download
M test/unittests/heap/memory-reducer-unittest.cc View 5 chunks +3 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. This prepares switch to the new foreground/background APIs.
5 years, 1 month ago (2015-10-26 14:16:54 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-10-27 12:07:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420363004/1
5 years, 1 month ago (2015-10-27 12:10:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 12:35:48 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 12:36:01 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ac5af5c12685ba6f9d87c135d9acae3e077a2fe
Cr-Commit-Position: refs/heads/master@{#31600}

Powered by Google App Engine
This is Rietveld 408576698