Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1420333006: Remove uses of std::unary_function and std::binary_function. (Closed)

Created:
5 years, 1 month ago by vmpstr
Modified:
4 years, 9 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, jshin+watch_chromium.org, kalyank, michaeln, nhiroki, noyau+watch_chromium.org, sadrul, James Su, tdanderson+overview_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of std::unary_function and std::binary_function. This patch removes unary and binary function, since those are deprecated in C++11. They also only provide two typedefs, so this cleans up some code. In rare cases where the typedefs are actually required, it's easier to just provide the typedef directly instead of deriving from one of these functions. BUG=593407 Committed: https://crrev.com/3abe3303bcbb2b24d7c21228f88114337347b674 Cr-Commit-Position: refs/heads/master@{#380179}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -48 lines) Patch
M ash/wm/overview/window_grid.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M components/bookmarks/browser/bookmark_index.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 1 2 chunks +2 lines, -7 lines 0 comments Download
M components/omnibox/browser/history_quick_provider_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/omnibox/browser/url_index_private_data.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M components/variations/entropy_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_storage_impl.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/label_ptr.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M ui/base/l10n/l10n_util_collator.h View 1 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
vmpstr
pkotwicz@chromium.org for ash/wm/ jochen@chromium.org for components/ and content/ mkwst@chromium.org for net/cookies/ brettw@chromium.org for tools/gn/ jshin@chromium.org ...
4 years, 9 months ago (2016-03-09 01:47:15 UTC) #2
Mike West
On 2016/03/09 at 01:47:15, vmpstr wrote: > mkwst@chromium.org for net/cookies/ net/cookies LGTM. Note that I'm ...
4 years, 9 months ago (2016-03-09 07:21:30 UTC) #3
jochen (gone - plz use gerrit)
please file a tracking bug for this I'd also recommend to add one of the ...
4 years, 9 months ago (2016-03-09 15:14:41 UTC) #5
Nico
lgtm Maybe add to the CL description why they're not useful ("They only provide typedefs ...
4 years, 9 months ago (2016-03-09 17:54:13 UTC) #6
vmpstr
On 2016/03/09 17:54:13, Nico wrote: > lgtm > > Maybe add to the CL description ...
4 years, 9 months ago (2016-03-09 18:47:06 UTC) #8
Nico
lgtm++
4 years, 9 months ago (2016-03-09 18:57:00 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-09 18:57:33 UTC) #10
vmpstr
+flackr as well for ash/wm/. Please take a look.
4 years, 9 months ago (2016-03-09 19:02:01 UTC) #12
flackr
lgtm thanks!
4 years, 9 months ago (2016-03-09 19:29:35 UTC) #13
flackr
lgtm thanks!
4 years, 9 months ago (2016-03-09 19:29:35 UTC) #14
vmpstr
mkwst@, landing this now, so you might have to rebase :)
4 years, 9 months ago (2016-03-09 19:31:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420333006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420333006/20001
4 years, 9 months ago (2016-03-09 19:32:23 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 19:38:28 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 19:41:21 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3abe3303bcbb2b24d7c21228f88114337347b674
Cr-Commit-Position: refs/heads/master@{#380179}

Powered by Google App Engine
This is Rietveld 408576698