Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 14203008: Remove useless SkRect::sort (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 8 months ago
Reviewers:
jvanverth1, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

mapRect does a sort internally

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
A little bit better: drawpointsdash_3_1_bw GPU c 40.20 40.83 -0.63 -1.6% drawpointsdash_1_1_bw GPU c 107.90 ...
7 years, 8 months ago (2013-04-25 19:52:57 UTC) #1
reed1
Hmmm, why doesn't SkMatrix::mapRect() already call sort?
7 years, 8 months ago (2013-04-25 20:09:51 UTC) #2
jvanverth1
On 2013/04/25 20:09:51, reed1 wrote: > Hmmm, why doesn't SkMatrix::mapRect() already call sort? It looks ...
7 years, 8 months ago (2013-04-25 20:56:37 UTC) #3
reed1
always happy to remove code. lgtm
7 years, 8 months ago (2013-04-25 21:00:00 UTC) #4
robertphillips
7 years, 8 months ago (2013-04-25 22:25:45 UTC) #5
Message was sent while issue was closed.
committed as r8871

Powered by Google App Engine
This is Rietveld 408576698