Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1420283020: [Interpreter]: Fix IC::GetSharedFunctionInfo for the interpreter. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Fix IC::GetSharedFunctionInfo for the interpreter. IC::GetSharedFunctionInfo get's the JS frame which called the IC. When the function is running in the interpreter, there is a Bytecode handler stub frame between the IC and the JS frame. Modify IC::GetSharedFunctionInfo to handle this. BUG=v8:4280 LOG=N Committed: https://crrev.com/859b15cacdef5d2315085744903dd047c64d1a60 Cr-Commit-Position: refs/heads/master@{#31865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/ic/ic.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283020/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283020/1
5 years, 1 month ago (2015-11-05 12:30:56 UTC) #2
rmcilroy
Toon, could you take a look please. I have some ideas for avoiding the need ...
5 years, 1 month ago (2015-11-05 12:31:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-05 13:01:41 UTC) #6
rmcilroy
ping? I'd like to land this so I can get the ignition bot up and ...
5 years, 1 month ago (2015-11-06 13:54:27 UTC) #7
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-06 18:44:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283020/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283020/1
5 years, 1 month ago (2015-11-06 18:58:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 19:21:16 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 19:21:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/859b15cacdef5d2315085744903dd047c64d1a60
Cr-Commit-Position: refs/heads/master@{#31865}

Powered by Google App Engine
This is Rietveld 408576698